Re: [Linphone-developers] linphone_core_redirect_call does not parse the input redirect_uri; bug?

[Eugenio Bargiacchi]

Hey,

I saw you did just patch it in GitHub, nice work =)

Just one point: I think you may have missed a "linphone_address_destroyed(real_parsed_url)" (or "linphone_address_unref(real_parsed_url)" since that seems to be deprecated). I say this since all other usages of interpret_url seem to free the address that way.

Thanks for the fast responses btw!

Eugenio

On Tue, Feb 16, 2016 at 10:20 AM, Eugenio Bargiacchi <address@hidden> wrote:

Hi Gautier,

I'm sorry, I wrote the call right in the subject but not in the text. Transfer does indeed work, it is the "redirect" command that fails in those cases. Which is weird since I believe they should be working in the same way.

In my subject I wrote the right function which is "linphone_core_redirect_call". I'm using the latest version from source pulled from github.

Sorry for the confusion.

Best,

Eugenio

On Tue, Feb 16, 2016 at 10:15 AM, Gautier Pelloux-Prayer <address@hidden> wrote:

Hi,

I do not reproduce the error and it looks strange to me because linphone_core_transfer_call use linphone_core_interpret_url to interpret the URL:

int linphone_core_transfer_call(LinphoneCore *lc, LinphoneCall *call, const char *url)
{
        char *real_url=NULL;
        LinphoneAddress *real_parsed_url=linphone_core_interpret_url(lc,url);
        /* do stuff ... */
}

I did not have any error when transfering call to address@hidden:5066 using:

> call someone
> transfer address@hidden:5066

What version are you using?

Cheers,

Gautier Pelloux-Prayer
Software Engineer @ Belledonne Communications

> On 15 Feb 2016, at 17:55, Eugenio Bargiacchi <address@hidden> wrote:
>
> Hello,
>
> Sorry if this is a duplicate, I sent it like a minute before my confirmation mail for the list arrived so I'm not sure whether my previous copy was silently discarded - it seems it was though.
>
> Anyway, I was trying to use the command "transfer" in linphonec, but it kept failing with the message:
>
> > 2016-02-15 16:59:15:033 ortp-error-uri parser error for [address@hidden:5066]
>
> Turns out this fails since the address I was putting in as a redirect (address@hidden:5066) does not begin with "sip:".
>
> However, other commands like transfer, call etc. work fine with inputs like these since in those cases the arguments get parsed by linphone_core_interpret_url and then to linphone_address_as_string. The former uses proxy information to parse the url and additionally fixes things like missing "sip:", and the latter turns it back into a char*.
>
> I was wondering if I should do a patch about it. My doubt comes from the fact that the argument to linphone_core_redirect_call seems to be a "const char* uri", while in the other cases the parameters are "url". I'm not 100% sure whether there is a difference within the core between the two things (URL and URI) or it just happened that the parameters were called like that.
>
> So are the two different? If so, would it be possible to allow transfer to use addresses without "sip:" anyway?
>
> If they are not different I'll put a pull request to GitHub. Thanks for your time.
>
> Best,
> Eugenio

> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-developers


_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers