Re: [Linphone-developers] Testing AES3 with EC and B256 on Android

[Johan Pascal]

Hi Eli,
no problem from your patch, zrtp.c has been badly modified after I 
included your patch to fix a problem on missing null termination in SAS 
but it was caused by an outdated version on bzrtp in linphone-android 
repository. I'll revert the bad fix, update bzrtp in linphone-android 
and everything shall get back working.

I shall soon include in bzrtp a report on which algorithm were used 
during the zrtp negotiation and add more tests on several cases, this 
should avoid this kind of errors in future.

Johan


On 27/04/15 14:50, Eli Burke wrote:
> Johan,
>
> Sorry my feature is causing you additional work!
> If the SAS is coming through as 4 characters even though B256 is
> enabled, then it is likely a problem in one of two places:
>
> Check ORTP: include/ortp/event.h
> -                       char sas[5]; // 4 characters
> +                       char sas[32]; // up to 31 + null characters
>
> Check ms2: src/crypto/zrtp.c
> -               memcpy(eventData->info.zrtp_sas.sas,sas,4);
> -               eventData->info.zrtp_sas.sas[4]=0;
> +               // support both b32 and b256 format SAS strings
> +               snprintf(eventData->info.zrtp_sas.sas,
> sizeof(eventData->info.zrtp_sas.sas), "%s", sas);
>
> b256 works correctly in my fork, but I have not re-synchronized my code
> in a couple of weeks; I may be able to take a look in the next day or two.
>
> -Eli
>
> > Begin forwarded message:
> >
> > Message: 1
> > Date: Sun, 26 Apr 2015 00:12:27 +0200
> > From: Johan Pascal <address@hidden
> > <mailto:address@hidden>>
> > To:address@hidden <mailto:address@hidden>
> > Subject: Re: [Linphone-developers] Testing AES3 with EC and B256 on
> > Android
> > Peter,
> > you're right, something is wrong with B256 SAS. SAS is not correctly
> > forwarded to linphone from mediastreamer2(only 4 chars in any case). It
> > looks like in your case B256 is not used at all while I think it may be
> > used but displayed SAS will be anyway, so I'm missing something else.
> >
> > If you can send me a wireshark trace of the ZRTP packets it may help.
> >
> > I'll fix the error I found in the coming days.
>
>
>
> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-developers