|
From: | Luis Soltero |
Subject: | Re: [Linphone-developers] linphone iOS 8 crash |
Date: | Fri, 19 Sep 2014 14:35:04 -0400 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
hm... not sure when things changed... in the old days you could use straight phone numbers as chat urls... now the word sip: must be in front of the number... looking at enum.c //4970072278724 bool_t is_enum(const char *sipaddress, char **enum_domain){ char *p; p=strstr(sipaddress,"sip:"); if (p==NULL) return FALSE; /* enum should look like sip:4369959250*/ else p+=4; if (is_a_number(p)){ if (enum_domain!=NULL){ *enum_domain=create_enum_domain(p); } return TRUE; } return FALSE; } I see that if "sip:phone_number" is present in the url then sip: is stripped and the chat room is allowed... However... if the sip is not present then the chat room is not created linphone_core_interpret_url now returns NULL which causes static LinphoneChatRoom * _linphone_core_get_or_create_chat_room(LinphoneCore* lc, const char* to) { LinphoneAddress *to_addr=linphone_core_interpret_url(lc,to); LinphoneChatRoom *ret; if (to_addr==NULL){ ms_error("linphone_core_get_or_create_chat_room(): Cannot make a valid address with %s",to); return NULL; } ret=_linphone_core_get_chat_room(lc,to_addr); linphone_address_destroy(to_addr); if (!ret){ ret=_linphone_core_create_chat_room_from_url(lc,to); } return ret; } to return NULL... so it seems that somewhere (not sure where the best place is to do this) is to prepend "sip:" to phone numbers that come out of the address book or to modify is_enum to return TRUE if a number is provided without sip: assuming that sip is implied of not supplied in the URL. This is the way it used to work. Not sure when "sip:" was enforced for phone numbers. I will hack the code to fix my issue by prepending "sip:" to phone numbers in ContactDetailsTableViewController.m line 661. --luis On 9/19/14, 11:48 AM, BIENKOWSKI
Guillaume wrote:
-- Luis Soltero, Ph.D., MCS Director of Software Development, CTO Global Marine Networks, LLC StarPilot, LLC Tel: +1.865.379.8723 Fax: +1.865.681.5017 E-Mail: address@hidden Web: http://www.globalmarinenet.net Web: http://www.redportglobal.com Web: http://www.starpilotllc.com |
[Prev in Thread] | Current Thread | [Next in Thread] |