Re: [Linphone-developers] [PATCH] Pass config command line to linphonec from linphonecsh

[Henrik Pauli]

The patch unfortunately contains an off by one error.  The argv length should be one more (I only accounted for the spaces separating the arguments, but not the final \0) -- so the 23rd line should be ++argv_len; instead of empty.

Attached slightly better commented and hopefully fixed patch.

On Tue, Aug 5, 2014 at 2:36 PM, Henrik Pauli <address@hidden> wrote:

I have sent this patch a few times before and I never got a reply so far, but it's still unapplied and I still think it's useful for linphonecsh users to be able to specify -c for example.

As written in the linphonecsh help:

>        init            : spawn a linphonec daemon (first step to make other actions)
>                        followed by the arguments sent to linphonec

In the original shell.c, this isn't exactly true, as Win32 linphoned is always spawned with `-c NUL`.

The patch attempts to copy the supplied args into the command line that will get eventually passed to CreateProcess.

(I'm not entirely sure why we are passing `-c /dev/null` and `-c NUL` to linphonecsh in the first place, when `--pipe` seems to be all we need, but I guess you know that better...)


Regards,
H.

argv_u.patch
Description: Text Data