Re: [Linphone-developers] [PATCH] Small usability improvement: select all text in uribar on focus

[Guillaume Beraudo]

Hello Ivan,


I am sorry for the late reply.

Thank you very much for your patch; unfortunately we cannot include it.
Here are the reasons.

The current behaviour of the address bar is:
- simple clic: cursor is placed at position;
- double clic: word at position is selected;
- triple clic: line is selected.

With your patch I fear that we will loose this granularity.

I am wondering, why you don't use the "keypad" to type pure phone numbers?


Now, let's say a word about the direction where the UI is going.

In the near future we wish to improve the keypad by adding a "keyboard
control" in addition to the current "mouse control".

There is also a redesign of the GUI addind a contact list from which you
can start a call or chat..


Cheers,

Guillaume Beraudo


On Wed, Nov 28, 2012 at 10:37:52PM +0600, Ivan Mironov wrote:
> Hello!
> 
> I think it will be useful for those who type phone numbers manually
> from keyboard.
> 
> -- 
> 

> From ff6960fdc51c5ee2f35a6bec07c66b240db820a2 Mon Sep 17 00:00:00 2001
> From: Ivan Mironov <address@hidden>
> Date: Mon, 26 Nov 2012 18:11:01 +0600
> Subject: [PATCH] Select all text in uribar on focus.
> 
> ---
>  gtk/main.c  | 16 +++++++++++++++-
>  gtk/main.ui |  1 +
>  2 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/gtk/main.c b/gtk/main.c
> index b773a5b..18acbb3 100644
> --- a/gtk/main.c
> +++ b/gtk/main.c
> @@ -614,7 +614,10 @@ static void load_uri_history(){
>                       GtkTreeIter iter;
>                       gtk_list_store_append(model,&iter);
>                       gtk_list_store_set(model,&iter,0,uri,-1);
> -                     if (i==0) gtk_entry_set_text(uribar,uri);
> +                     if (i==0){
> +                             gtk_entry_set_text(uribar,uri);
> +                             
> gtk_editable_select_region(GTK_EDITABLE(uribar),0,-1);
> +                     }
>               }
>               else break;
>       }
> @@ -778,6 +781,17 @@ void linphone_gtk_uri_bar_activate(GtkWidget *w){
>       linphone_gtk_start_call(w);
>  }
>  
> +gboolean linphone_gtk_uri_bar_button_press_event(GtkWidget *w, GdkEvent 
> *event, gpointer data){
> +     (void)event;
> +     (void)data;
> +     if (!gtk_widget_has_focus(w)){
> +             gtk_widget_grab_focus(w);
> +             gtk_editable_select_region(GTK_EDITABLE(w),0,-1);
> +             return TRUE;
> +     }
> +     return FALSE;
> +}
> +
>  
>  void linphone_gtk_terminate_call(GtkWidget *button){
>       gboolean is_conf;
> diff --git a/gtk/main.ui b/gtk/main.ui
> index a57b799..8b603cf 100644
> --- a/gtk/main.ui
> +++ b/gtk/main.ui
> @@ -684,6 +684,7 @@
>                                      <property 
> name="primary_icon_sensitive">True</property>
>                                      <property 
> name="secondary_icon_sensitive">True</property>
>                                      <signal name="activate" 
> handler="linphone_gtk_uri_bar_activate" swapped="no"/>
> +                                    <signal name="button-press-event" 
> handler="linphone_gtk_uri_bar_button_press_event" swapped="no"/>
>                                    </object>
>                                    <packing>
>                                      <property name="expand">True</property>
> -- 
> 1.7.11.7
> 

> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-developers