Re: [Linphone-developers] small patches

[Jonathan Rosser]

On 11/07/12 11:03, Guillaume Beraudo wrote:
> Hi Jonathan,
> 
> Thank you for your patches and sorry for the late response.
> 
> I have merged the patches 2 and 3 in mediastreamer.
> However I don't understand patch 1.
> 
> The video window is composed of:
> - remote video (also called main video);
> - self-view in a corner (also called local preview).
> 
> What issue are you trying to fix?
> 

When the application is first opened, i.e. not in a call, the aspect
ratio of the self view (which takes the whole window) is I think wrong
when using a 16:9 source. It fills the whole square-ish window and does
not have black bars at the top and bottom.

The function x11video_set_vsize() appears to actually set s->wsize,
which I think is the cause of this error. Things then go wrong in
ms_layout_compute().

Does this make sense?

Thanks for applying the other patches.

Best Regards,
Jonathan.