[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Linphone-developers] small patches
From: |
Guillaume Beraudo |
Subject: |
Re: [Linphone-developers] small patches |
Date: |
Wed, 7 Nov 2012 12:03:10 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi Jonathan,
Thank you for your patches and sorry for the late response.
I have merged the patches 2 and 3 in mediastreamer.
However I don't understand patch 1.
The video window is composed of:
- remote video (also called main video);
- self-view in a corner (also called local preview).
What issue are you trying to fix?
Guillaume
On Thu, Oct 11, 2012 at 03:22:47PM +0100, Jonathan Rosser wrote:
> Looks like the mailing list is becoming more active, so I'll try again
> to get some small patches integrated.
>
> 1) X11 preview window aspect ratio is wrong. Very noticeable with 16:9
> sources.
>
> 2) Very trivial fix to add support for UYVY pixel formats. (Needed for
> my mediastreamer plugin for Blackmagic Decklink cards.... anyone
> interested in that?)
>
> 3) Useful debugging when a codec is not supported
>
> If these could be reviewed and considered for inclusion in linphone,
> that would be great.
>
> Thanks,
> Jonathan.
> From 68565b075ed5f8dfc024825dab9f901426b46807 Mon Sep 17 00:00:00 2001
> From: Jonathan Rosser <address@hidden>
> Date: Wed, 17 Nov 2010 11:06:53 +0000
> Subject: [PATCH 1/3] fix aspect ratio of preview window
>
> ---
> src/x11video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/x11video.c b/src/x11video.c
> index 7a1e2c7..794713c 100644
> --- a/src/x11video.c
> +++ b/src/x11video.c
> @@ -457,7 +457,7 @@ static void x11video_process(MSFilter *f){
> static int x11video_set_vsize(MSFilter *f,void *arg){
> X11Video *s=(X11Video*)f->data;
> ms_filter_lock(f);
> - s->wsize=*(MSVideoSize*)arg;
> + s->vsize=*(MSVideoSize*)arg;
> ms_filter_unlock(f);
> return 0;
> }
> --
> 1.7.9.5
>
> From b922047f1cc79f62bd6e5d804c2a32ad318c2c62 Mon Sep 17 00:00:00 2001
> From: Jonathan Rosser <address@hidden>
> Date: Tue, 8 May 2012 09:03:42 +0100
> Subject: [PATCH 2/3] support UYVY pixel formats
>
> ---
> src/msvideo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/msvideo.c b/src/msvideo.c
> index 7a144be..58faf82 100644
> --- a/src/msvideo.c
> +++ b/src/msvideo.c
> @@ -83,6 +83,7 @@ int ms_picture_init_from_mblk_with_size(MSPicture *buf,
> mblk_t *m, MSPixFmt fmt,
> break;
> case MS_YUY2:
> case MS_YUYV:
> + case MS_UYVY:
> memset(buf,0,sizeof(*buf));
> buf->w=w;
> buf->h=h;
> --
> 1.7.9.5
>
> From 0b760a4080713a2a916d298eb53ad821ed11cce6 Mon Sep 17 00:00:00 2001
> From: Jonathan Rosser <address@hidden>
> Date: Wed, 9 May 2012 20:06:29 +0100
> Subject: [PATCH 3/3] add more debugging about why a codec is not supported
>
> ---
> src/msfilter.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/src/msfilter.c b/src/msfilter.c
> index c1d198b..247aa1c 100644
> --- a/src/msfilter.c
> +++ b/src/msfilter.c
> @@ -59,8 +59,13 @@ void ms_filter_unregister_all(){
> }
>
> bool_t ms_filter_codec_supported(const char *mime){
> - if (ms_filter_get_encoder(mime)!=NULL
> - && ms_filter_get_decoder(mime)!=NULL) return TRUE;
> + MSFilterDesc *enc = ms_filter_get_encoder(mime);
> + MSFilterDesc *dec = ms_filter_get_decoder(mime);
> +
> + if(enc!=NULL && dec!=NULL) return TRUE;
> +
> + if(enc==NULL) ms_message("Could not find encoder for %s", mime);
> + if(dec==NULL) ms_message("Could not find decoder for %s", mime);
> return FALSE;
> }
>
> --
> 1.7.9.5
>
> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-developers