Hi Valentin,
I merged your patch into git, master branch.
After doing some tests, I realize that the way the gnome
notification server is presenting notifications with actions is not
very good looking.
So I modified a bit your patch to remove the action buttons for call
hangup/answer, and instead a simple bubble notification for the
incoming call.
At the same time, the status icon is blinking with an "incoming call
icon", so that the user understands that something is happening with
linphone. It can then click on the status icon, to show up the main
interface and answer.
I fixed also a few memory leaks while allocating strings
(g_strdup_printf and so on).
Thank you again for your patch, great job.
Regards,
Simon
On 01/09/2011 18:50, Valentin Beraudo wrote:
I moved
notify_uninit() to the end of main(), which is indeed a better
place for it, as the core is no longer active.
Also changed the tone for a 400Hz, 300ms duration, 8s silence one.
Sounds indeed more "waiting tone"-like.
Thanks,
Valentin
ps : fixed patch for linphone attached
Le 30/08/2011 22:07, Simon Morlat a écrit :
Ok looks much better !
I have a few other remarks:
1) why did call notify_uninit() in linphone_gtk_close() ?
Because linphone_gtk_close() is called when the user dismisses
the main window, not when linphone leaves. Don't you think the
end of main() would be a better place for notify_uninit() ?
2) Regarding the tone to indicate an incoming call, I have found
that this kind of tone is actually normalized by ITU-T E180.
Here is an extract:
10
<extract>
Call waiting tone
10.1
The call waiting tone is used to advise a subscriber who is
engaged on a call that another subscriber is
attempting to call.
10.2
The tone is intended to be sufficiently alerting to succeed in
its purpose without interfering with existing
conversation.
10.3
The recommend specification of the tone is one or more cycles
defined by a frequency f in the range:
f : 400 to 450 Hz
and with a cadence (frequency sequence) as follows:
a) f on 300 to 500 ms, silence 8 to 10 s (f = 300 ms is
preferable to the longer tone since the ongoing conversation
would be interrupted for a briefer interval); or
b) f on 100 to 200 ms, silence 100 to 200 ms, f on 100 to 200 ms
(the total to be no more than 500 ms); 8 to 10 s
silence.
Other tones may be acceptable.
10.4
The second and subsequent cycles may be at a lower level than
the initial one.
10.5
Where the tone continues for more than one cycle, it should
preferably cease when it is no longer possible to
accept the waiting call.
</extract>
As you see it is not a dtmf (dual tone) but a single tone that
repeats every 8-10 seconds. Could you modify the tone settings
to reflect this specification ?
Otherwise I will do it, just tell me if you are lacking time.
Regards,
Simon
_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers
|