Re: [Linphone-developers] lots of bugs resolution and multicalls improvements

[Simon Morlat]

Hi Aurélien,

See my comments below:

Le vendredi 04 février 2011 à 08:26 +0000, Aurelien Bouin a écrit :
> Hi Simon,
> 
> I don't have much time to try and test your new version... Because without 
> the new states that I implemented I have to change my upper API about the 
> distant call status...
> You have not implemented the bugs I attached with the patch too like :
> => ringing are not sent when multi call in callbacks.c in the function 
> call_ringing...
It is not a good idea to start "normal" ring when a call is already
active. This is disturbing for the active call, and also won't work on
systems where soundcard cannot be opened multiple time. I suggest that a
good implementation would be to render a small beep periodically within
the context of the active call, using the MSDtmfGen filter plumbed into
the Rtp->SoundWrite graph. It is not as simple, as the other calls might
also be totally inactive, thus in this case playing the real ring tone
would be possible.


> => the fact that the upper API could handle the refer
> => the DTMF reception whatever the call it received it
These two patches are interesting and I 'd like to merge them, however
it would be much simpler if in the future you send them as individual
patches, rather than a big patch implementing multiple unrelated
features.


> => the fact that the call do not handle video but it do not change the params 
> (linphone_call_start_media_streams)
Can you elaborate more about this one ?
Is it that unaccepted video is not reported in the
linphone_call_get_current_params() ?
If it is that, then I think we fixed it already.

Anyway thank you for your contributions Aurélien. Despite I do not
always merge all of the them, it raises up real problems and suggests
solutions, which makes the software getting progress.

Best regards,

Simon