linphone-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] Re: Re : linphone multi call branch


From: Simon Morlat
Subject: Re: [Linphone-developers] Re: Re : linphone multi call branch
Date: Wed, 02 Jun 2010 18:03:09 +0200

Hi Aurélien,
Thank you for noticing this bug. I fixed it I think more simply in the
git tree (both branches). I just check whether
SalStreamDescription::port is != 0 . In offeranswer.c, in case no codecs
are present, the port are set to zero to tell the stream is unaccepted.

Simon

Le vendredi 28 mai 2010 à 04:38 -0700, Aurelien Bouin a écrit :
> Hi,
> Here are two patchs one concerning mediastreamer2 and the other linphone, 
> because of segfault when a communication occured with incompatible video 
> codecs...
> example A have H263 and B H263-1998, we will get a segfault
> Thank you,
> 
> Aurélien
> 
> --- En date de : Ven 28.5.10, Aurelien Bouin <address@hidden> a écrit :
> 
> > De: Aurelien Bouin <address@hidden>
> > Objet: Re: [Linphone-developers] Re: Re : linphone multi call branch
> > À: "Simon Morlat" <address@hidden>
> > Cc: address@hidden
> > Date: Vendredi 28 mai 2010, 8h28
> > Hi,
> > 
> > --- En date de : Jeu 27.5.10, Simon Morlat <address@hidden>
> > a écrit :
> > 
> > > De: Simon Morlat <address@hidden>
> > > Objet: Re: [Linphone-developers] Re: Re : linphone
> > multi call branch
> > > À: "Aurelien Bouin" <address@hidden>
> > > Cc: address@hidden
> > > Date: Jeudi 27 mai 2010, 11h38
> > > Hi Aurélien,
> > > 
> > > I don't understand why you commented out the adding of
> > the
> > > SDP in the
> > > ACK.
> > Because for example when a call is hold the ACK send a SDP
> > that modify the previous one sent in the (re)INVITE and
> > fallowing the RFC3261->17.1.1.3 Construction of the ACK :
> > 
> > "Although any request MAY contain a body, a body in an ACK
> > is special
> >    since the request cannot be rejected if
> > the body is not understood.
> >    Therefore, placement of bodies in ACK for
> > non-2xx is NOT RECOMMENDED,
> >    but if done, the body types are
> > restricted to any that appeared in
> >    the INVITE, assuming that the response to
> > the INVITE was not 415.  If
> >    it was, the body in the ACK MAY be any
> > type listed in the Accept
> >    header field in the 415."
> > Maybe we should control when we have to send the SDP ???
> > > In case an offer is sent within a 200Ok, an answer
> > must be
> > > sent in the
> > > ACK. Maybe you run into a trouble with that feature ?
> > > Concerning the timeout notification, I think adding a
> > > callback just for
> > > that is a bit heavy. Why not just using the gstate
> > callback
> > > and getting
> > > the status from the call log ?
> > > There is already an enum entry for that:
> > > /**
> > >  * Enum representing the status of a call
> > >  * @ingroup call_logs
> > > **/
> > > typedef enum _LinphoneCallStatus { 
> > >     LinphoneCallSuccess, /**< The call
> > > was sucessful*/
> > >     LinphoneCallAborted, /**< The call
> > > was aborted */
> > >     LinphoneCallMissed /**< The call was
> > > missed (unanswered)*/
> > > } LinphoneCallStatus;
> > > 
> > > Just to avoid to grow too much the
> > LinphoneCoreVTable...
> > Does it mean that we have to check the value of gstate into
> > a while or something ? Actually I implemented it the way
> > that if it is not defined into the vtable parameter sent to
> > linphone_core_new, it won't change anything ? I feel like
> > controlling liblinphone by callbacks is a good way than
> > checking state or value ?
> > I am really open to any suggestion,
> > Thank you,
> > 
> > Aurélien
> > 
> > > 
> > > Simon
> > > 
> > > Le jeudi 27 mai 2010 à 08:37 +0000, Aurelien Bouin a
> > > écrit :
> > > > Hi,
> > > > Thank you for merging, here is a new little patch
> > that
> > > solves :
> > > > -> a segfault when the timeout occured
> > > > -> avoir to send SDP when ACK is sent, because
> > it
> > > could change the INVITE SDP ... and a ACk should
> > never
> > > contain SDP offer...
> > > > Thank you,
> > > > 
> > > > Aurélien
> > > > 
> > > > --- En date de : Ven 21.5.10, Simon Morlat <address@hidden>
> > > a écrit :
> > > > 
> > > > > De: Simon Morlat <address@hidden>
> > > > > Objet: Re: [Linphone-developers] Re: Re :
> > > linphone multi call branch
> > > > > À: "Aurelien Bouin" <address@hidden>
> > > > > Cc: address@hidden
> > > > > Date: Vendredi 21 mai 2010, 14h59
> > > > > Thank you, it is now merged. I also
> > > > > merged master into dev_multicall so
> > > > > that the two branches gets close together.
> > > > > 
> > > > > Simon
> > > > > 
> > > > > Le mardi 18 mai 2010 à 01:53 -0700,
> > Aurelien
> > > Bouin a
> > > > > écrit :
> > > > > > Hi,
> > > > > > Here is a new patch that improves the
> > multi
> > > call, add
> > > > > the
> > > > > > acknoledgement of the resume and the
> > pause,
> > > that
> > > > > permits the WIN32
> > > > > > compilation(Sleep function), etc ...
> > > > > > Thank you,
> > > > > > 
> > > > > > 
> > > > > > Aurélien
> > > > > > 
> > > > > > --- En date de : Mar 11.5.10, Aurelien
> > Bouin
> > > <address@hidden>
> > > > > a
> > > > > > écrit :
> > > > > >         
> > > > > >         De:
> > > Aurelien
> > > > > Bouin <address@hidden>
> > > > > >         Objet:
> > > Re:
> > > > > [Linphone-developers] Re: Re : linphone
> > multi
> > > call
> > > > > >     
> > >    branch
> > > > > >         À: address@hidden
> > > > > >         Cc:
> > > "Simon
> > > > > Morlat" <address@hidden>
> > > > > >         Date:
> > > Mardi 11
> > > > > mai 2010, 11h30
> > > > > >         
> > > > > >         Hey,
> > > > > >         I
> > > found a bug
> > > > > when a call is updated, if I am right we
> > have to
> > > > > >         add
> > > the function
> > > > > sal_media_description_ref . . . that was
> > > > > >         kinda
> > > hard to
> > > > > see that it comes from here . . .
> > > > > >         Thank
> > > you,
> > > > > >         
> > > > > >         
> > > > > >     
> > >    Aurélien
> > > > > >         
> > > > > >         --- En
> > > date de :
> > > > > Lun 10.5.10, Vadim Lebedev <address@hidden>
> > > > > >         a
> > > écrit :
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    De: Vadim Lebedev <address@hidden>
> > > > > >         
> > >    
> > > > >    Objet: Re: [Linphone-developers] Re:
> > > Re :
> > > > > linphone
> > > > > >         
> > >    
> > > > >    multi call branch
> > > > > >         
> > >    
> > > > >    À: address@hidden
> > > > > >         
> > >    
> > > > >    Date: Lundi 10 mai 2010, 15h52
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    Hi Aurelien,
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    I'm not sure this is a correct
> > > behaviour,
> > > > > (keep
> > > > > >         
> > >    
> > > > >    sending when held),  pretty
> > > often
> > > > > >         
> > >    
> > > > >    you'll get back ICMP "port
> > > unreachable
> > > > > packets" in
> > > > > >         
> > >    
> > > > >    these case
> > > > > >         
> > >    
> > > > >    Maybe the best way is to control
> > > this
> > > > > beahviour
> > > > > >         
> > >    
> > > > >    through configuration option
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    Thanks
> > > > > >         
> > >    
> > > > >    Vadim
> > > > > >         
> > >    
> > > > >    On 05/10/2010 02:56 PM, Aurelien
> > > Bouin
> > > > > wrote: 
> > > > > >         
> > >    
> > > > >    > Hi,
> > > > > >         
> > >    
> > > > >    > This patch fix a header problem
> > > under
> > > > > win32, and keep sending audio and video
> > when
> > > holded on, we
> > > > > have to do that when we are setting as
> > sendonly .
> > > . .
> > > > > >         
> > >    
> > > > >    > Thank you,
> > > > > >         
> > >    
> > > > >    > 
> > > > > >         
> > >    
> > > > >    > Aurélien
> > > > > >         
> > >    
> > > > >    > 
> > > > > >         
> > >    
> > > > >    > --- En date de : Ven 7.5.10,
> > > Simon
> > > > > Morlat <address@hidden>
> > > > > a écrit :
> > > > > >         
> > >    
> > > > >    > 
> > > > > >         
> > >    
> > > > >    >   
> > > > > >         
> > >    
> > > > >    > > De: Simon Morlat <address@hidden>
> > > > > >         
> > >    
> > > > >    > > Objet: Re: Re : linphone
> > > multi
> > > > > call branch
> > > > > >         
> > >    
> > > > >    > > À: "Aurelien Bouin"
> > > <address@hidden>
> > > > > >         
> > >    
> > > > >    > > Cc: address@hidden
> > > > > >         
> > >    
> > > > >    > > Date: Vendredi 7 mai
> > > 2010,
> > > > > 17h28
> > > > > >         
> > >    
> > > > >    > > merged to dev_multicall
> > > branch.
> > > > > >         
> > >    
> > > > >    > > 
> > > > > >         
> > >    
> > > > >    > > Thanks
> > > > > >         
> > >    
> > > > >    > > 
> > > > > >         
> > >    
> > > > >    > > Simon
> > > > > >         
> > >    
> > > > >    > > 
> > > > > >         
> > >    
> > > > >    > > Le mardi 04 mai 2010 à
> > > 15:07
> > > > > +0000, Aurelien Bouin a
> > > > > >         
> > >    
> > > > >    > > écrit :
> > > > > >         
> > >    
> > > > >    > >     
> > > > > >         
> > >    
> > > > >    > > > Hi,
> > > > > >         
> > >    
> > > > >    > > > Here is a new patch
> > > to be
> > > > > able to answer to one
> > > > > >         
> > >    
> > > > >    > > >   
> > > > >    
> > > > > >         
> > >    
> > > > >    > > incoming call . . .
> > > actually it
> > > > > was not possible before,
> > > > > >         
> > >    
> > > > >    > > because get_current_call
> > > > > returned NULL if you were not
> > > > > >         
> > >    
> > > > >    > > already in AVRunning ...
> > > > > >         
> > >    
> > > > >    > >     
> > > > > >         
> > >    
> > > > >    > > > Thank you,
> > > > > >         
> > >    
> > > > >    > > > 
> > > > > >         
> > >    
> > > > >    > > > Aurélien
> > > > > >         
> > >    
> > > > >    > > > 
> > > > > >         
> > >    
> > > > >    > > > --- En date de : Lun
> > > > > 3.5.10, Aurelien Bouin <address@hidden>
> > > > > >         
> > >    
> > > > >    > > >   
> > > > >    
> > > > > >         
> > >    
> > > > >    > > a écrit :
> > > > > >         
> > >    
> > > > >    > >     
> > > > > >         
> > >    
> > > > >    > > > > De: Aurelien
> > > Bouin
> > > > > <address@hidden>
> > > > > >         
> > >    
> > > > >    > > > > Objet: linphone
> > > multi
> > > > > call branch
> > > > > >         
> > >    
> > > > >    > > > > À: address@hidden
> > > > > >         
> > >    
> > > > >    > > > > Cc: "Simon
> > > Morlat"
> > > > > <address@hidden>
> > > > > >         
> > >    
> > > > >    > > > > Date: Lundi 3
> > > mai
> > > > > 2010, 10h45
> > > > > >         
> > >    
> > > > >    > > > > Hi,
> > > > > >         
> > >    
> > > > >    > > > > Attached is a
> > > patch
> > > > > that permits to set/get a
> > > > > >         
> > >    
> > > > >    > > > > 
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    > > void *
> > > > > >         
> > >    
> > > > >    > >     
> > > > > >         
> > >    
> > > > >    > > > > user_pointer
> > > from a
> > > > > LinphoneCall...
> > > > > >         
> > >    
> > > > >    > > > > Thank you,
> > > > > >         
> > >    
> > > > >    > > > > 
> > > > > >         
> > >    
> > > > >    > > > > Aurélien
> > > > > >         
> > >    
> > > > >    > > > > 
> > > > > >         
> > >    
> > > > >    > > > > 
> > > > > >         
> > >    
> > > > >    > > >
> > > >   
> > > > >    
> > > > > >         
> > >    
> > > > >    > > > > 
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    > > >   
> > >    
> > > > > 
> > > > > >         
> > >    
> > > > >    > > >   
> > > > >    
> > > > > >         
> > >    
> > > > >    > 
> > > > > >         
> > >    
> > > > >    >
> > > > >
> > _______________________________________________
> > > > > >         
> > >    
> > > > >    > Linphone-developers mailing
> > > list
> > > > > >         
> > >    
> > > > >    > address@hidden
> > > > > >         
> > >    
> > > > >    > http://lists.nongnu.org/mailman/listinfo/linphone-developers
> > > > > >         
> > >    
> > > > >    >   
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >    -----La pièce jointe associée
> > > suit-----
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > >    
> > > > >   
> > > _______________________________________________
> > > > > >         
> > >    
> > > > >    Linphone-developers mailing list
> > > > > >         
> > >    
> > > > >    address@hidden
> > > > > >         
> > >    
> > > > >    http://lists.nongnu.org/mailman/listinfo/linphone-developers
> > > > > >         
> > >    
> > > > >    
> > > > > >         
> > > > > >         
> > > > > >         
> > > > > >     
> > >    -----La pièce
> > > > > jointe associée suit-----
> > > > > >         
> > > > > >     
> > > > >   
> > > _______________________________________________
> > > > > >     
> > > > >    Linphone-developers mailing list
> > > > > >         address@hidden
> > > > > >         http://lists.nongnu.org/mailman/listinfo/linphone-developers
> > > > > >         
> > > > > > 
> > > > > 
> > > > > 
> > > > >
> > > > 
> > > > 
> > > >       
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> > _______________________________________________
> > Linphone-developers mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/linphone-developers
> >
> 
> 
>       





reply via email to

[Prev in Thread] Current Thread [Next in Thread]