Re : [Linphone-developers] bug in call_updated?

[Aurelien Bouin]

Hi,
In multicall I found the same error yersteday and sent a patch, we probably 
have to add the lines you mentionned...

Aurélien

--- En date de : Mar 11.5.10, Peter Meerwald <address@hidden> a écrit :

> De: Peter Meerwald <address@hidden>
> Objet: [Linphone-developers] bug in call_updated?
> À: address@hidden
> Cc: "Simon Morlat" <address@hidden>
> Date: Mardi 11 mai 2010, 17h12
> Hello,
> 
> I'm getting crashes with linphone (latest) and invalid
> read/writes in 
> valgrind:
> 
> Connected.
> linphonec>
> ==14771== Invalid read of size 4
> ==14771==    at 0x40407DD:
> sal_media_description_unref (sal.c:49)
> ==14771==    by 0x4047DF7: call_updated
> (callbacks.c:231)
> ==14771==    by 0x4044440: sal_iterate
> (sal_eXosip2.c:789)
> ==14771==    by 0x403D93E: linphone_core_iterate
> (linphonecore.c:1651)
> ==14771==    by 0x804C084: linphonec_idle_call
> (linphonec.c:921)
> ...
> 
> please have a look at callbacks.c:call_updated()
> 
>    
> linphone_core_stop_media_streams(lc,call);
>    
> linphone_core_init_media_streams(lc,call);
>     if (call->resultdesc)
>        
> sal_media_description_unref(call->resultdesc);
>    
> call->resultdesc=sal_call_get_final_media_description(op);
>     // XXX missing? if (call->resultdesc)
> sal_media_description_ref(call->resultdesc);
>     if (call->resultdesc &&
> !sal_media_description_empty(call->resultdesc)){
>        
> linphone_connect_incoming(lc,call);
>     }
> 
> I think there should be the indicated line (see XXX above)
> if (call->resultdesc) 
>    
> sal_media_description_ref(call->resultdesc);
> so the code is similar to the one in call_ack();
> unfortunately I do not 
> fully understand what's going on but I hope you find time
> to check... at 
> least it solved my problem :)
> 
> thanks, regards, p.
> 
> -- 
> 
> Peter Meerwald
> Kaigasse 3 / 8
> A-5020 Salzburg / AUSTRIA
> +43-664-2444418 (mobile)
> 
> _______________________________________________
> Linphone-developers mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/linphone-developers
>