Re: [Linphone-developers] Mediastreamer2: check if a filter is a source

[damico]

Sorry, I sent the mail to a wrong address....

Aymeric Moizard ha scritto:
> On Tue, 10 Mar 2009, damico wrote:
>
> > Hi Aymeric,
>
> > Unfortunately the PUMP flag is contained in the description instance 
> > and so it is fixed for all instances of a filter. By using this flag 
> > I can't use the same filter with different behavior.
> >
> > What I'm looking for is a way to use two different instances of the 
> > same filter like filter or source independently. If I set the PUMP 
> > flag for one of two the result is that both filters become sources...
>
> You can declare 2 different filter struct which are using the exact
> same methods! The only difference can then be the name of the filter
> and 2 MSFilterDesc instead of one.
>
> That should make it?
Yes, of course, I can do it.... The problem is : I hate the cut/paste :)
By cut and paste we can duplicate code and bugs and not just code.


> > I'm wondering if my patch is not backward compatible... what are the 
> > functionalities that can result broked by applying that patch?
>
> May be 99% backward compatible: some filter probably assume there is a
> queue, so if you let them execute as source with no allocated input 
> queue,
> they will crash.
It sounds like "there are some filters that are buggy" :)

Anyway, I can do by duplicating the description and filter id in order
to have two filters with different behaviour.
Now, that is the best approach because no modifications in common code
-> no new bugs :)

Regards

--Michele