linphone-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Linphone-developers] payload check bandwidth is broken


From: damico
Subject: [Linphone-developers] payload check bandwidth is broken
Date: Mon, 01 Sep 2008 15:04:50 +0200
User-agent: Mozilla-Thunderbird 2.0.0.9 (X11/20080110)

Hi Simon,

I've compiled from cvs HEAD and start linphonec from empty linphonerc (download_bw and upload_bw set to 0). In that scenario every codec is refused by linphone_core_check_payload_type_usability with the message
payload *** is not usable

Please review my patch that would fix that issue.

Regards

### Eclipse Workspace Patch 1.0
#P linphone_upstream
Index: coreapi/misc.c
===================================================================
RCS file: /sources/linphone/linphone/coreapi/misc.c,v
retrieving revision 1.75
diff -u -r1.75 misc.c
--- coreapi/misc.c      26 Aug 2008 13:31:14 -0000      1.75
+++ coreapi/misc.c      1 Sep 2008 12:23:17 -0000
@@ -230,8 +230,7 @@
          the audio bandwidth is refined to the selected codec
        */
        if (!linphone_core_in_call(lc)) update_allocated_audio_bandwidth(lc);
-       min_audio_bw=get_min_bandwidth(linphone_core_get_download_bandwidth(lc),
-                                       linphone_core_get_upload_bandwidth(lc));
+       min_audio_bw=get_min_bandwidth(lc->dw_audio_bw,lc->up_audio_bw);
        min_video_bw=get_min_bandwidth(lc->dw_video_bw,lc->up_video_bw);
 
        switch (pt->type){

reply via email to

[Prev in Thread] Current Thread [Next in Thread]