Re: upgrading a songbook from 2.14 to 2.18

[David Kastrup]

Maurits Lamers <maurits@weidestraat.nl> writes:

> Hi,
>
>> convert-ly does text replacements.  It is not a full parser.  If text
>> replacements are supposed to work, you need to write your text in a way
>> that the replacement patterns cover.  Stuff like putting # on one line
>> and a corresponding opening paren on the next line are just too weird
>> for those writing the conversion rules to have foreseen.
>> 
>> So first try formatting your source in a somewhat common manner and then
>> try running convert-ly.
>
> I did notice this way of indenting though and changed it before
> running Lilypond, but I didn't anticipate that convert-ly would also
> check for scheme code patterns.

It doesn't "check" for style.  It catches some patterns and converts
them and overlooks others.

The 2.14 to 2.16 upgrade overhauled # syntax significantly, changed the
meaning of $ for LilyPond, changed the meaning of $ in embedded Scheme
inside of #{ #}, replaced #(ly:export ...) with $... and a few other
comparatively invasive things, all using regular expressions.

It did a pretty good job on LilyPond's own code base formatted in
LilyPond's own style, but things like #<some whitespace> or
#(<some whitespace> are so unusual that they have not made it into the
patterns.

-- 
David Kastrup