Am So., 15. Dez. 2019 um 21:47 Uhr schrieb Thomas Morley
<address@hidden>:
Am So., 15. Dez. 2019 um 21:17 Uhr schrieb Michael Käppler <address@hidden>:
Hi all,
a few days ago I submitted a snippet to the LSR (title "Coloring
successive intervals"). I can see it in the snippet database,
but not in the webpage. The "Contributing" section of LSR states, that:
"Once the snippet is in, it has to be reviewed and approved by one of
the LSR editors,
and then it must be digested by the search engine. Within a few days,
you should be able to see your snippet online."
Is this still valid in principle? Or maybe did I something wrong?
Cheers,
Michael
In principle ... yes.
Though, I seem to be the only remaining regular active LSR editor, and
my time is limited.
Thus it may take some more time than the LSR "Contributing" section says.
Announcing it on the list helps, ofcourse.
I'll take a look soon.
As promised I had a look.
Many thanks for your snippet!
For now:
First I changed the LSR button "Large snippet" to "Standalone snippet".
It's a very rare case "Large snippet" is apppropriate, usualy for
snippets outputting multipe pages. In almost every other case it's
better to uncheck the buttons or to go for "Standalone snippet".
Otherwise compressed and (imho) ugly images are output by the LSR.
Please always observe a 80-characters line-width limit for your code.
Your snippet contains some advanced code. In such cases I often want
to discuss things a bit deeper. So:
What bugged me right from the first glance over it, is your need to
define several engravers, one for each case.
I think one engraver should do the work for _all_ those cases.
Attached you'll find my suggestion for this, along with better
indentation, 80-chars-line-width along with some minor adjustments.
Please have a look.
Nevertheless that can't be the final state, imho.
May I ask you to add inline code-comments what's done and why?
There are not so many examples of scheme-engravers around. One
thoroughly commented would be great.
Additionally, I'd go for more self-explaining variable-names.
P.e. "dt-st": for me it's an arbitrary collection of characters, with
a hyphen somewhere ;)
Thanks,
Harm
interval-color-engraver-lsr.ly