|
From: | Lukas-Fabian Moser |
Subject: | Re: Extend Whiteout property |
Date: | Mon, 10 Sep 2018 23:05:10 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Hi Urs, thanks for all the detailed explanations!
So it would be nice if someone with the C++ knowledge could have a look at https://github.com/lilypond/lilypond/pull/3 and comment on it there. Note: the goal is not to merge the branch into the Github mirror but only to provide review. Once there is agreement on the code someone should sheperd the patch through the regular review process.
I just might add that, I think, the C++ part of the changes is almost "trivial" (one had to make sure that the stencil-whiteout gets activated not only for boolean- or number-valued 'whiteout' property, but for pairs [of numbers] as well). The real work is all scheme, namely in scm/stencil.scm.
Best Lukas
[Prev in Thread] | Current Thread | [Next in Thread] |