|
From: | Paul |
Subject: | Re: Pitched Trill Collision |
Date: | Sun, 2 Oct 2016 16:40:12 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/01/2016 02:20 PM, David Kastrup wrote:
Paul <address@hidden> writes:Indeed, that's a good example for this, and if we check whether ledger lines overlap horizontally or not before merging them, then we'll have solved all these cases. :-) Adding some of these cases to the regression tests will also help.Are they even guaranteed to have the same thickness? If not, merging will be quite a chore.
Yes, I think so, as far as this code is concerned. The ledger-line-thickness property (of StaffSymbol) determines the thickness of all the ledgers for a given LedgerLineSpanner, and this apparently includes ledgers for pitched trill notes, even though the note head is smaller.
I had some time today and I'm happy to say that despite still feeling a bit like a tourist in C++ land, I have a patch that fixes the problem. Uploading it for review soon.
Cheers, -Paul
[Prev in Thread] | Current Thread | [Next in Thread] |