lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCHES - Countdown for May 17th


From: Jonas Hahnfeld
Subject: Re: PATCHES - Countdown for May 17th
Date: Sun, 17 May 2020 15:53:25 +0200
User-agent: Evolution 3.36.2

Am Sonntag, den 17.05.2020, 15:50 +0200 schrieb David Kastrup:
> Jonas Hahnfeld <address@hidden> writes:
> > Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG:
> > > > > I think for now it's pushing to staging.  Either from the command
> > > > > line, or because you have set staging as your destination branch in
> > > > > the GUI, in which case you can use a button (usually starting by
> > > > > rebase).
> > > > 
> > > > If using the command line, just make sure to push the rebased commit
> > > > to the merge request first so that GitLab marks it correctly.  I
> > > > haven't found a way to set the "merged" state manually after the
> > > > commits have hit staging...
> > > 
> > > It seems we should provide a small script 'lilypond-commit', to be
> > > used by everyone...
> > 
> > Just use the UI to merge. This will probably become mandatory when
> > integrating CI which I'm preparing right now.
> 
> It is much more direct to manage one's commits/issues on the command
> line.  We should not lightly forego that possibility.

I agree for editing commit messages and more complex rebases, but
merging should be left to an entity that enforces policy. Right now
this is patchy pushing from staging to master. In my book, this should
be GitLab when it has CI information.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]