[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove deprecated context properties (issue 560030044 by address@hid
|
From: |
v . villenave |
|
Subject: |
Re: Remove deprecated context properties (issue 560030044 by address@hidden) |
|
Date: |
Sun, 10 May 2020 01:08:13 -0700 |
On 2020/05/09 18:25:03, lemzwerg wrote:
>
https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-properties.scm#newcode609
> scm/define-context-properties.scm:609: merge rests when this is set to
true.")
> While you are at it, please fix indentation (i.e., no indentation for
the
> continuation line).
Acknowledged.
> LGTM. This issue also adds some scheme code and a conversion rule –
they are
> different commits, right?
Should they really be? The scheme code (largely inspired by Harm BTW :-)
is only needed for the snippet (which will get updated through next
makelsr anyway).
As for define-context-properties.scm, it’s used in the doc so I thought
it’d make sense to have that in the same commit that the @funindex
cleanup.
V.
https://codereview.appspot.com/560030044/