[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Prevent race condition in `-dfont-ps-resdir` (issue 561810045 by add
|
From: |
trueroad |
|
Subject: |
Re: Prevent race condition in `-dfont-ps-resdir` (issue 561810045 by address@hidden) |
|
Date: |
Sat, 09 May 2020 07:19:20 -0700 |
Thank you for your reviewing.
https://codereview.appspot.com/561810045/diff/551840043/scm/backend-library.scm
File scm/backend-library.scm (right):
https://codereview.appspot.com/561810045/diff/551840043/scm/backend-library.scm#newcode143
scm/backend-library.scm:143: ;; When the directory already exists, it
raises system-error.
On 2020/05/09 13:30:15, lemzwerg wrote:
> s/When/If/
Done.
https://codereview.appspot.com/561810045/diff/551840043/scm/backend-library.scm#newcode161
scm/backend-library.scm:161: ;; When the file already exists, it raises
system-error.
On 2020/05/09 13:30:15, lemzwerg wrote:
> s/When/If/
Done.
https://codereview.appspot.com/561810045/diff/551840043/scm/backend-library.scm#newcode188
scm/backend-library.scm:188: ;; When the file already exists, it raises
system-error.
On 2020/05/09 13:30:15, lemzwerg wrote:
> s/When/If/
Done.
https://codereview.appspot.com/561810045/diff/551840043/scm/framework-ps.scm
File scm/framework-ps.scm (right):
https://codereview.appspot.com/561810045/diff/551840043/scm/framework-ps.scm#newcode284
scm/framework-ps.scm:284: from file `~a' index ~a...")
On 2020/05/09 13:30:15, lemzwerg wrote:
> Maybe
>
> for subfont ~a of file ~a")
>
> ?
Done.
https://codereview.appspot.com/561810045/diff/551840043/scm/framework-ps.scm#newcode544
scm/framework-ps.scm:544: (_ "Font file `~a' already exists, skipping.")
On 2020/05/09 13:30:16, lemzwerg wrote:
> s/\./.../ to be in sync with other, similar error messages.
>
> Alternatively, you might do s/\.\.\././ in the other error messages
:-)
Done.
https://codereview.appspot.com/561810045/