lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Remove if/else for shift/raise (issue 573770043 by address@hidden)


From: jonas . hahnfeld
Subject: Remove if/else for shift/raise (issue 573770043 by address@hidden)
Date: Fri, 01 May 2020 13:59:35 -0700

https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):

https://codereview.appspot.com/573770043/diff/553990043/lily/stencil-integral.cc#newcode966
lily/stencil-integral.cc:966: copy.raise (y_pos[i] - my_y);
hm, the old code passed different arguments in the two branches:
copy.shift (x_pos[i] - my_x);
vs.
copy.shift (y_pos[i] - my_y);

and
copy.raise (y_pos[i] - my_y);
vs.
copy.raise (x_pos[i] - my_x);

AFAICS this has nothing to do with commutativity of shift and raise.

https://codereview.appspot.com/573770043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]