[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Added transition lines for lyrics (issue 565750043 by address@hidden
From: |
davidgrant . no |
Subject: |
Re: Added transition lines for lyrics (issue 565750043 by address@hidden) |
Date: |
Sun, 08 Mar 2020 13:32:03 -0700 |
On 2020/03/08 15:21:22, hanwenn wrote:
> I think it would be better to do this as something that doesn't
require special
> syntax at first, ie. some identifier.
>
One of my motivations for introducing '->' is that it keeps the lyrics
clean and easy to read. Music that uses vowel transitions can have a
_lot_ of them.
> Also, it looks like the transition-engraver is almost a literal copy
of the
> hyphen engraver. Wouldn't this be much simpler if you'd implement the
transition
> as a layout tweak to a hyphen?
I thought it might be best to separate transitions from hyphens, and use
the line-spanner-interface to draw the arrow. The requirements for
spacing are slightly different (transitions should never be omitted even
in tight spacing), and also some other properties differ (e.g.
minimum-space). So even though transitions are similar in many ways to
hyphens I wonder if they are distinct enough to be separated. But I will
certainly look into tweaking hyphens instead, as -- as you have pointed
out -- there is currently a lot of duplicated code.
Thank you both for the feedback! I'll have another go at this.
https://codereview.appspot.com/565750043/
- Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/08
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), lemzwerg, 2020/03/08
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), hanwenn, 2020/03/08
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), Dan Eble, 2020/03/08
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), Han-Wen Nienhuys, 2020/03/09
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), Dan Eble, 2020/03/09
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), Han-Wen Nienhuys, 2020/03/10
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), David Kastrup, 2020/03/10
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), Dan Eble, 2020/03/10
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), hanwenn, 2020/03/08
Re: Added transition lines for lyrics (issue 565750043 by address@hidden),
davidgrant . no <=
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/10
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), hanwenn, 2020/03/10
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/10
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), nine . fierce . ballads, 2020/03/10
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), lemzwerg, 2020/03/11
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/11
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), lemzwerg, 2020/03/11
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/12
Re: Added transition lines for lyrics (issue 565750043 by address@hidden), lemzwerg, 2020/03/12