[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Explain dead code for GUILE2 (issue 547470043 by address@hidden)
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: Explain dead code for GUILE2 (issue 547470043 by address@hidden) |
|
Date: |
Fri, 24 Jan 2020 10:05:08 -0800 |
https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc
File lily/main.cc (right):
https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447
lily/main.cc:447: /* this code is dead, but keeping this around until we
sort the
LGTM, but ...
"'Mostly dead' is 'slightly alive.'"
It sounds like you think you might need to reinstate this. Consider
keeping the #if GUILE2 and wrapping the code in if (false) {...}. That
way it will have to remain compilable in the meantime, so it will be
closer to ready when you need it.
Also, the title of this review is "Explain dead code for GUILE2," but
the change appears to go beyond explanation into modification.
https://codereview.appspot.com/547470043/