[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Replace deprecated functions from string module (issue 566920044 by
|
From: |
jonas . hahnfeld |
|
Subject: |
Re: Replace deprecated functions from string module (issue 566920044 by address@hidden) |
|
Date: |
Sun, 12 Jan 2020 02:24:05 -0800 |
On 2020/01/12 02:19:20, dak wrote:
On 2020/01/12 01:13:51, dak wrote:
>
https://codereview.appspot.com/566920044/diff/549120043/python/convertrules.py
> File python/convertrules.py (right):
>
>
https://codereview.appspot.com/566920044/diff/549120043/python/convertrules.py#newcode3898
> python/convertrules.py:3898: mods = str.join (re.findall ("\n(" +
wordsyntax +
> r")\s*=\s*\\with(?:\s|\\|\{)")
> File
>
"/usr/local/tmp/lilypond/out/lib/lilypond/current/python/convertrules.py",
line
> 3892, in conv
> mods = str.join (re.findall ("\n(" + wordsyntax +
> r")\s*=\s*\\with(?:\s|\\|\{)")
> TypeError: findall() takes at least 2 arguments (1 given)
>
> I'd call that a case of insufficient testing... Sometimes our tests
don't
cover
> everything and one has to check out things on one's own.
Just pushed a fix to staging.
Whoops, thanks for handling this!
https://codereview.appspot.com/566920044/