Re: Issue XXXX: Clean up to_string () etc. (issue 583320043 by address@hidden)

[lemzwerg]

> s += EXTSEP; // append a char to s
> s += ext_; // append a string to s

> — vs. —

> s += EXTSEP + ext_;
>       \___________/
>       make a string
> \________________/
>   append it to s

> Either one could involve memory allocation, but I deemed it more
> likely in the latter case.  I don't have reason to suspect this is a
> performance bottlenck, but given that I had to touch the line, and
> that it wasn't a major rewrite, I decided to try to improve it.

I'm not sure that it is an improvement.  Today, compilers use very good
optimization tools; I can imagine that the performance of both lines is
exactly the same – or that the one-line version performs even better
since the compiler can handle the memory allocation internally in an
optimized way.  Only a profiler can give a clear answer, and this is
most certainly dependent on the platform and the compiler.

I thus favor code that is easiest to understand by the user, or which
looks nice.  Normally, I very much favor a vertical flow of source code,
but in this particular case the compact one-liner looks easier to
comprehend.

https://codereview.appspot.com/583320043/