lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by addres


From: Lukas-Fabian Moser
Subject: Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by address@hidden)
Date: Thu, 11 Jul 2019 19:49:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

Hi Carl,

Perhaps this patch should also revert
87eb2f9fe1be3a532675fe4b7322bbba5a60ba5c

since that patch was a workaround, rather than a real fix, as
demonstrated during this troubleshooting thread.

Carl


https://codereview.appspot.com/570830043/

I'm afraid I do not understand the connection between the overdone-notehead patch you refer to and the rounding-issue patch regarding chord-notehead-placing. They do not seem to be linked to me.

But I noticed that your old patch 87eb2f9fe, which was supposed to fix issue https://sourceforge.net/p/testlilyissues/issues/4693/, seems to only fix that issue at "normal" staff sizes. See for instance:

\version "2.18"

#(set-global-staff-size 90)

\layout {
  \override Score.StaffSymbol.layer = 100
}

\new Voice \with {
  \override NoteHead.color = #red
  } {
  \relative {
    f'4 a c e \bar "|."
  }
}

(And, for the record, 87eb2f9fe introduced https://sourceforge.net/p/testlilyissues/issues/5530/, as Malte reminded us.)

So it seems to me that that patch should probably be reconsidered, but I think not without being related to issues 5303/5522 (which are what the current patch is about).

Best
Lukas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]