lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: misplaced-note-head bug (issue 5303)


From: Lukas-Fabian Moser
Subject: Re: misplaced-note-head bug (issue 5303)
Date: Thu, 4 Jul 2019 16:24:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

Hi James,

a) How to decide which fix is "better"? (My guess that using floats
might pose the danger of rounding errors adding up until something bad
happens - probably only for huge chords comprising hundreds of notes,
but I'd tend to favor the solution with rounding.)
That question is above my pay-grade

I went with my "feeling" described earlier now, heartened by the regtests showing no problems that I could spot.

b) Would anybody be willing to shepherd a patch through the review process?
Sure I can do that for you. 'Git format-patch master' if you would be so kind? 
:)
Thanks much! See attached.
c) Does the situation warrant inclusion of a new regression test? (The
example in the bug report on
https://sourceforge.net/p/testlilyissues/issues/5303/ would be suitable
I think.)
Put one in - it's easier to ask for forgiveness than permission right?

I'm sorry - I didn't realize that this can be done by just adding a file to input/regression. Done now.

Lukas

Attachment: 0001-In-loop-calculating-the-attachments-of-chord-node-he.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]