lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: misplaced-note-head bug (issue 5303)


From: James Lowe
Subject: Re: misplaced-note-head bug (issue 5303)
Date: Thu, 04 Jul 2019 11:37:46 +0100 (BST)

Hello

On Thu, 4 Jul 2019 12:31:46 +0200, Lukas-Fabian Moser <address@hidden> wrote:

> Folks,
> 
> only now was I able to do regression tests regarding my proposed fix(es) 
> of the misplaced-note-head-bug (issue 5303):
> 
> The bug is caused by the integer-cast
> 
> lastpos = int (p);
> 
> in lily/stem.cc:629.
> 
> Replacing it by either
> i) lastpos = p; // use float value
> or
> ii) lastpos = int (round (p)) // correctly round to integer
> 
> resolves the bug. Neither variant introduces regressions (differences 
> only in in test-output-distance and rest-dot-position, the latter being, 
> I think, unrelated - the seemingly random position changes of dots to 
> multi-voice simultaneous rests).
> 
> Questions:
> 
> a) How to decide which fix is "better"? (My guess that using floats 
> might pose the danger of rounding errors adding up until something bad 
> happens - probably only for huge chords comprising hundreds of notes, 
> but I'd tend to favor the solution with rounding.)

That question is above my pay-grade

> 
> b) Would anybody be willing to shepherd a patch through the review process?

Sure I can do that for you. 'Git format-patch master' if you would be so kind? 
:)

> 
> c) Does the situation warrant inclusion of a new regression test? (The 
> example in the bug report on 
> https://sourceforge.net/p/testlilyissues/issues/5303/ would be suitable 
> I think.)
> 

Put one in - it's easier to ask for forgiveness than permission right?

James



reply via email to

[Prev in Thread] Current Thread [Next in Thread]