[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (issue 56079
From: |
lemzwerg |
Subject: |
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (issue 560790043 by address@hidden) |
Date: |
Sun, 30 Jun 2019 19:54:33 -0700 |
Some typographic issues.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode185
Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file
allows English note names to be used.
Please use `@file' for file names.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode240
Documentation/notation/world.itely:240: @ref{Common notation for
non-Western music}
I think there is a comma missing at the end of line.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode244
Documentation/notation/world.itely:244: @file{ly/arabic.ly}
Ditto. There are more such cases below.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode257
Documentation/notation/world.itely:257: are defined in either
@code{hel-arabic} or @file{arabic.ly} files and
@file{hel-arabic.ly} ?
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode262
Documentation/notation/world.itely:262: music. Arabic maqams only allow
for limited modulations, due to the
Please use two spaces after a full stop that ends a sentence.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode266
Documentation/notation/world.itely:266: of music;
Instead of a semicolon I think it's better to use either a full stop or
a colon.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode281
Documentation/notation/world.itely:281: below (e.g. @notation{bayati},
@notation{hussaini}, @notation{saba}, and
e.g.,
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode282
Documentation/notation/world.itely:282: @notation{ushaq} can be
indicated in the same way. These are all
@notation{ushaq})
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode290
Documentation/notation/world.itely:290: parenthesis for those that are
modulations of their base maqam.
parentheses
https://codereview.appspot.com/560790043/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (issue 560790043 by address@hidden),
lemzwerg <=