[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by
|
From: |
pkxgnugitcl |
|
Subject: |
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by address@hidden) |
|
Date: |
Sat, 08 Jun 2019 05:04:09 -0700 |
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4
File aclocal.m4 (right):
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode77
aclocal.m4:77: STEPMAKE_ADD_ENTRY($3, $2)
On 2019/06/07 06:47:17, lemzwerg wrote:
This looks strange, at least here in appspot. It appears as if one
level of
indentation got lost.
Done.
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode96
aclocal.m4:96: true
On 2019/06/07 06:47:17, lemzwerg wrote:
Ditto, and many other lines in this file, too.
Yes, I guess find/replace didn't work. I'll fix these manually.
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode399
aclocal.m4:399: fi
Cannot see corresponding 'if' line for this 'fi'. Again I maybe missing
something obvious.
https://codereview.appspot.com/552770043/