[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5848 flower:

labels: --> Fixed_2_21_1
status: Started --> Fixed
Patch: push -->
Type: Enhancement --> Maintainability
Comment:

commit 619b73ec3420961b27b84cded3fb778167431701
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Sat Apr 11 17:58:46 2020 +0200
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Wed Apr 15 09:10:39 2020 +0200

    Issue 5848/3: Rename my_round to round_halfway_up

    The function differs from std::round() in the handling of negative
    numbers: While std::round() rounds halfway cases away from zero,
    round_halfway_up (as the name suggests) rounds them up for historic
    reasons.
    This can apparently be relied upon at least when manually positioning
    ties (input/regression/tie-single-manual.ly). In the long run, these
    cases should be identified and taken care of individually. Keep this
    function for the time being, but DO NOT USE in newly written code.

    While passing by, move some system headers last (this helps avoid issues
    that one of LilyPond&#39;s headers depends on other system headers being
    loaded first) and add them if apparently used in the file.

commit 97449f88f477bf3fafe520f27b4585320127de30
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Thu Mar 12 20:07:31 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Wed Apr 15 09:10:35 2020 +0200

    Issue 5848/2: Rewrite String_convert::to_upper, ::to_lower via std::transform

commit 3dcc231bdd97b25943154cb22a6ec48ee58c543f
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Thu Mar 12 18:23:41 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Wed Apr 15 09:10:25 2020 +0200

    Issue 5848/1: Remove unused includes of libc-extension.hh

[issues:#5848] flower: Clean up libc-extension

Status: Fixed
Labels: Fixed_2_21_1
Created: Tue Mar 17, 2020 09:03 PM UTC by Jonas Hahnfeld
Last Updated: Wed Apr 15, 2020 02:46 AM UTC
Owner: Jonas Hahnfeld

flower: Clean up libc-extension

Individual commits:
1) Remove unused includes of libc-extension.hh

2) Rewrite String_convert::to_upper, ::to_lower via std::transform

3) Rename my_round to round_halfway_up

The function differs from std::round() in the handling of negative
numbers: While std::round() rounds halfway cases away from zero,
round_halfway_up (as the name suggests) rounds them up for historic
reasons.
This can apparently be relied upon at least when manually positioning
ties (input/regression/tie-single-manual.ly). In the long run, these
cases should be identified and taken care of individually. Keep this
function for the time being, but DO NOT USE in newly written code.

While passing by, move some system headers last (this helps avoid issues
that one of LilyPond's headers depends on other system headers being
loaded first) and add them if apparently used in the file.

http://codereview.appspot.com/553740043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5848 flower: Clean up libc-extension
Date:	Wed, 15 Apr 2020 08:27:25 -0000