[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5895 define-m

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5895 define-markup-command-internal -> module-define-markup-command!

Date:

Wed, 15 Apr 2020 02:53:56 -0000

Patch: review --> countdown
Comment:

Patch on countdown for April 17th

[issues:#5895] define-markup-command-internal -> module-define-markup-command!

Status: Started
Created: Sun Apr 12, 2020 12:58 PM UTC by David Kastrup
Last Updated: Sun Apr 12, 2020 03:09 PM UTC
Owner: David Kastrup

define-markup-command-internal -> module-define-markup-command!

Tangible benefits of this approach are not all that clear, and it
doesn't cover define-markup-list-command in the current form either,
so it warrants more work before committing or even deciding to commit.
Particularly so since for convenience it reverts a previous patch
combining the internals of define-markup-command and
define-markup-list-command, in order to illustrate the approach just
on the former.

However, it works and provides a basis for discussion. The principal
idea is to provide a version of define-markup-command that is not
specific to the current module and not a macro, in a similar vein to
how module-define! complements define , and use this in the parser
rather than the previous somewhat fuzzier
define-markup-command-internal .

Additional commits:

Add Lily_lexer::current_scope () function

Revert "Express define-markup-list-command-internal using define-markup-command-internal"

This reverts commit 9f1683921621b612b94080d506ee317b058b29c8.

http://codereview.appspot.com/547920045

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.