[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5834 Fix most

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5834 Fix most encoding problems with Guile 2.x

Date:

Wed, 11 Mar 2020 07:26:13 -0000

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
Comment:

commit f756cab383d91faa6430a1c7f1b041f7855721a9
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Sat Mar 7 19:44:48 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Wed Mar 11 08:24:23 2020 +0100

    Issue 5834/2: Use UTF-8 for all conversions to / from Scheme

    LilyPond really expects all input to be encoded in UTF-8, and we should
    not let GUILE 2.x mangle with it.

commit cbac8d5d3113b2b224956b555c147ccc230ab14a
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Sat Mar 7 00:03:15 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Wed Mar 11 08:24:23 2020 +0100

    Issue 5834/1: Treat possibly incomplete UTF-8 as binary

    replace_special_characters checks that the substring doesn&#39;t start
    mid-UTF-8, but it does not guarantee that it ends in a complete glyph.
    So just explicitly treat it as binary when creating the SCM.
    While modifying the function, avoid comparison of zero-length substrings.

[issues:#5834] Fix most encoding problems with Guile 2.x

Status: Fixed
Labels: Fixed_2_21_0
Created: Sat Mar 07, 2020 06:46 PM UTC by Jonas Hahnfeld
Last Updated: Wed Mar 11, 2020 06:54 AM UTC
Owner: Jonas Hahnfeld

Fix most encoding problems with Guile 2.x

Individual commits:
1) Treat possibly incomplete UTF-8 as binary

replace_special_characters checks that the substring doesn't start
mid-UTF-8, but it does not guarantee that it ends in a complete glyph.
So just explicitly treat it as binary when creating the SCM.
While modifying the function, avoid comparison of zero-length substrings.

2) Use UTF-8 for all conversions to / from Scheme

LilyPond really expects all input to be encoded in UTF-8, and we should
not let GUILE 2.x mangle with it.

http://codereview.appspot.com/555420043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

[Prev in Thread]

Current Thread

[Next in Thread]