[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5779 SVG: Per

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5779 SVG: Permit 'e' to appear in SVG font glyph paths

Date:

Thu, 27 Feb 2020 15:58:04 -0000

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
Comment:

pushed as

commit 915ccbf455aac0e0e597435ae85fc1015da84e13
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Fri Feb 21 12:20:25 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Thu Feb 27 16:55:52 2020 +0100

    Issue 5779/2: Also allow &#39;+Aa,&#39; in SVG path descriptions

    See https://www.w3.org/TR/2011/REC-SVG11-20110816/paths.html#PathDataBNF
    Note that - must be first in the character class or it will specify
    a range of characters (as the first version of this patch did).

commit e45b5186b25e4ec4077621d917aaa014be342535
Author:     Simon Tatham &lt;address@hidden&gt;
AuthorDate: Thu Feb 20 18:24:52 2020 +0000
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Thu Feb 27 16:55:48 2020 +0100

    Issue 5779/1: [SVG] Permit &#39;e&#39; to appear in SVG font glyph paths.

    The definition of &#39;glyph-path-regexp&#39; will only match a &lt;path d=&#34;...&#34;&gt;
    element if the contents of the &#39;d&#39; attribute do not include the letter
    e. But the SVG spec permits coordinates to be given in C-style
    exponential notation such as 9.8e-5. If a glyph in an SVG font uses
    that ability, extract-glyph will fail, and the glyph will be silently
    omitted from the output file.

[issues:#5779] SVG: Permit 'e' to appear in SVG font glyph paths

Status: Fixed
Labels: Fixed_2_21_0
Created: Fri Feb 21, 2020 10:51 AM UTC by pkx166h
Last Updated: Wed Feb 26, 2020 07:29 PM UTC
Owner: Jonas Hahnfeld
Attachments:

0001-SVG-Permit-e-to-appear-in-SVG-font-glyph-paths.patch (1.1 kB; text/plain)

On 20/02/2020 18:33, Simon Tatham wrote:

A user of my notation font Gonville reported to me this week that they
had tried to use the Lilypond SVG backend with Gonville, and had found
that everything worked fine except that the sharp signs were
mysteriously missing from the output.

I debugged the problem and found that this happened because Fontforge
had generated the SVG path string for that glyph in a way that happened
to include the floating-point literal "9.91821e-05", written in
scientific notation, and that the 'glyph-path-regexp' definition in
output-svg.scm was failing to match the path string as a result, because
it doesn't permit the letter 'e'.

I was able to work around the issue by editing my SVG font file to
re-express that number as 0.0000991821, without the 'e'. But as far as I
can see, scientific notation of that form is legal per the SVG spec:
https://www.w3.org/TR/2011/REC-SVG11-20110816/paths.html#PathDataBNF

Applying the attached patch against output-svg.scm also solved the
problem for me, and I think it's a better fix.

Cheers,
Simon

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.