lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5779 SVG:


From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5779 SVG: Permit 'e' to appear in SVG font glyph paths
Date: Fri, 21 Feb 2020 13:57:20 -0000

Am Freitag, den 21.02.2020, 11:33 +0000 schrieb Simon Tatham:

Jonas Hahnfeld <
address@hidden

wrote:
looking at
https://sourceforge.net/p/testlilyissues/issues/5779/
and
the grammar you linked, I think the regular _expression_ is also missing
'+Aa,'. Does it make sense to fuse attached patch?

The idea looks sensible to me, but I think you've made a mistake in the
regular _expression_ syntax. The character '-' has to appear immediately
after the open bracket, otherwise it's taken to be the punctuation in a
range such as "A-Z". So the character class
[+-MmZzLlHhVvCcSsQqTtAa0-9,.Ee\n ] will match (at least) any character
between '+' and 'M'.

If you start the brackets with [-+Mm...] instead of [+-Mm...] then I
think it does what you intended.

Absolutely correct, good spot. Luckily (for my testing) '-' is between
'+' and 'M', but that's actually too broad. Will fix the patch.

Thanks
Jonas


[issues:#5779] SVG: Permit 'e' to appear in SVG font glyph paths

Status: Started
Created: Fri Feb 21, 2020 10:51 AM UTC by pkx166h
Last Updated: Fri Feb 21, 2020 11:22 AM UTC
Owner: pkx166h
Attachments:

On 20/02/2020 18:33, Simon Tatham wrote:

A user of my notation font Gonville reported to me this week that they
had tried to use the Lilypond SVG backend with Gonville, and had found
that everything worked fine except that the sharp signs were
mysteriously missing from the output.

I debugged the problem and found that this happened because Fontforge
had generated the SVG path string for that glyph in a way that happened
to include the floating-point literal "9.91821e-05", written in
scientific notation, and that the 'glyph-path-regexp' definition in
output-svg.scm was failing to match the path string as a result, because
it doesn't permit the letter 'e'.

I was able to work around the issue by editing my SVG font file to
re-express that number as 0.0000991821, without the 'e'. But as far as I
can see, scientific notation of that form is legal per the SVG spec:
https://www.w3.org/TR/2011/REC-SVG11-20110816/paths.html#PathDataBNF

Applying the attached patch against output-svg.scm also solved the
problem for me, and I think it's a better fix.

Cheers,
Simon


Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]