[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5729 Fix Synt

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
Comment:

pushed to staging

commit 456b465c8657fa5346db9f122473e8e991e238c7
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Sun Feb 2 15:35:29 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Thu Feb 6 12:03:06 2020 +0100

    Issue 5729/2: musicxml2ly: Remove drummode

    This code is fundamentally broken: NoteEvent::ly_expression() and
    NoteEvent::chord_element_ly() miss a &#39;%&#39; to format the string. Instead
    the code &#34;calls&#34; the string which Python meets with a SyntaxWarning.

    Trying to hit this code path, musicxml only sets the drum_type attribute
    in Note::initialize_drum_event() called from Note::to_lily_object().
    However as far as I understand the MusicXML specification, a &lt;note&gt;
    must always have either a &lt;pitch&gt;, or &lt;unpitched&gt;, or &lt;rest&gt;.
    If I try to construct an (invalid) input with only an instrument name,
    musicxml2ly breaks at another function, so this is really dead code.

commit 72952db2cd4c548fda98a35b751906745cfe5ed5
Author:     Jonas Hahnfeld &lt;address@hidden&gt;
AuthorDate: Sun Feb 2 14:13:52 2020 +0100
Commit:     Jonas Hahnfeld &lt;address@hidden&gt;
CommitDate: Thu Feb 6 12:02:59 2020 +0100

    Issue 5729/1: abc2ly: Fix SyntaxWarning

    This line still works in Python 3.8, but it throws a warning:
    &gt; SyntaxWarning: &#34;is&#34; with a literal. Did you mean &#34;==&#34;?

[issues:#5729] Fix SyntaxWarning's

Status: Fixed
Labels: Fixed_2_21_0
Created: Sun Feb 02, 2020 02:52 PM UTC by Jonas Hahnfeld
Last Updated: Thu Feb 06, 2020 06:16 AM UTC
Owner: Jonas Hahnfeld

Fix SyntaxWarning's

Individual changes:
1) abc2ly: Fix SyntaxWarning

This line still works in Python 3.8, but it throws a warning:

SyntaxWarning: "is" with a literal. Did you mean "=="?

2) musicxml2ly: Remove drummode

This code is fundamentally broken: NoteEvent::ly_expression() and
NoteEvent::chord_element_ly() miss a '%' to format the string. Instead
the code "calls" the string which Python meets with a SyntaxWarning.

Trying to hit this code path, musicxml only sets the drum_type attribute
in Note::initialize_drum_event() called from Note::to_lily_object().
However as far as I understand the MusicXML specification, a <note>
must always have either a <pitch>, or <unpitched>, or <rest>.
If I try to construct an (invalid) input with only an instrument name,
musicxml2ly breaks at another function, so this is really dead code.</rest></unpitched></pitch></note>

http://codereview.appspot.com/559440043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5729 Fix SyntaxWarning's
Date:	Thu, 06 Feb 2020 11:26:03 -0000