[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4550 Avoid "u

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: countdown -->
Comment:

commit 00929c7b4bbd276e82cb392dfbada0f408204778 (HEAD -&gt; dev/issue-4550-using-namespace-std, origin/staging)
Author: Dan Eble &lt;address@hidden&gt;
Date:   Wed Jan 22 08:23:59 2020 -0500

    Issue 4550/3: Remove remaining &#34;using namespace std;&#34; with a script

    The script is posted in the code review:
    https://codereview.appspot.com/579240043/

commit 6f4128e1f359daf38a3caf2c0e4ad68e16c10540
Author: Dan Eble &lt;address@hidden&gt;
Date:   Thu Jan 9 13:04:18 2020 -0500

    Issue 4550/2: Avoid &#34;using namespace std;&#34; in included files

    These are manual changes in preparation for an automated removal of
    &#34;using namespace std;&#34;.

    Mostly, these are additions of using-declarations for commonly used
    types and containers (e.g. std::string, std::vector) to *.cc files so
    that they will continue to build after the big removal.

commit 9dc0905b7686ad51b386585acd69f742c1f677df
Author: Dan Eble &lt;address@hidden&gt;
Date:   Fri Jan 10 11:40:43 2020 -0500

    Issue 4550/1: Remove flower/include/parray.hh

[issues:#4550] Avoid "using" directives in included files

Status: Fixed
Labels: Fixed_2_21_0
Created: Mon Aug 10, 2015 10:02 AM UTC by Anonymous
Last Updated: Thu Jan 23, 2020 05:35 PM UTC
Owner: Dan Eble

Originally created by: *anonymous

Originally created by: nine.fie...@gmail.com
Originally owned by: nine.fie...@gmail.com

"using namespace std;" seems to be *everywhere* in Lilypond. It appears in *.cc files before headers are included. It appears in header files too.

"using" directives should not be used where they might affect more than the current file.

The patch for this issue will have to wait for a handful of issues that I found along the way to be fixed, but here is the summary:
* eliminate "using namespace std;"
* add "std::" to everything in *.hh files (and other included files)
* add "using std::whatever;" in *.cc files for common types (e.g. string, vector)
* add "std::" in *.cc files for functions (e.g. swap) and other less common things (e.g. less)

Latest attempt: https://codereview.appspot.com/579240043/
Earlier attempts: ~~https://codereview.appspot.com/254670043/~~

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4550 Avoid "using" directives in included files
Date:	Fri, 24 Jan 2020 16:01:49 -0000