[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5646 Switch to Python 3.x

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

Am Mittwoch, den 22.01.2020, 13:03 +0000 schrieb David Kastrup:

"Jonas Hahnfeld" address@hidden writes:

David, did you even carefully read my response?!? I'm doing exactly
that!

No, you aren't. They are not supposed to be 3 separate Rietveld issues
but a single issue with 2 updates to it.

This means it will be impossible to update the individual commits. But
I can do this if you insist.

Let me try again:
I have three commits locally: the switch itself, a generated patch by
2to3 and another patch to make it actually work. See above for the
three links, with this one being the SF issue to link them.
Now I can put this into one large issue on Rietveld, but you actually
don't want to review the second patch. So I have them separate to see
the manual changes that do need review.

That's why one puts them into separate updates so that people can select
the diffs to review.

On push, I will fuse them into one commit because a patch won't help
with bisection (git bisect might end up picking a commit from the
branch that doesn't actually compile).

That's why one puts just a merge commit in the mainline. See the
example I gave.

This is what I get for
$ git log --oneline --graph 5385d029e3...92ae8d8679
5385d029e3 Merge branch 'issue3648' into staging
|\
| * 703dca1fd6 Run scripts/auxiliar/makelsr.py
| * b570097f37 Issue 3648/7: Give several examples of durations without explicit pitches
| * 80e4d58800 Issue 3648/6: Regtest for rhythmic sequences.
| * f1163b25f8 Issue 3648/5: Explain isolated durations in NR "Rhythms"
| * 33dd448c34 Issue 3648/4: Let \displayLilyMusic deal with pure rhythms
| * 1a1c0afede Issue 3648/3: Pitchless durations inherit previous pitch when scorifying
| * 7958611915 Let copy-repeat-chord return the copy target for efficiency
| * 2527d43953 Issue 3648/2: Slight documentation amendment for RhythmicStaff in NR
| * 3dc88bc7db Issue 3648/1: Isolated durations in music sequences now stand for unpitched notes
|/
fc830bf324 Interpret #{ -3 #} as postevent rather than negative number

So $ git bisect might pick up an intermediate commit (3dc88bc7db to
703dca1fd6) and ask you to test it. This might work in your example,
but actually not for switching to Python 3.x for the mentioned reasons.

Jonas

---

[issues:#5646] Switch to Python 3.x

Status: Started
Created: Thu Dec 19, 2019 06:15 PM UTC by Jonas Hahnfeld
Last Updated: Wed Jan 22, 2020 01:39 PM UTC
Owner: Jonas Hahnfeld

Switch to Python 3.x

Find and require at least Python 3.5 which will allow us to address
some deprecation warnings, most notably about the 'imp' module.
The major version 3.5 was first released in September 2015 and should
be available in all major distributions, including Ubuntu LTS 16.04 and
18.04 as well as CentOS/RHEL 7.x and 8.x.

http://codereview.appspot.com/545370043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto