[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5659 Clean up to_string () etc.

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• labels: --> Fixed_2_21_0
• status: Started --> Fixed
• Patch: push -->
• Type: Enhancement --> Maintainability
• Comment:

commit 9cf6b20aefd79be13c7678d4cc834434b7ca000d (HEAD, refs/rewritten/onto, origin/staging)
Author: Dan Eble <address@hidden>
Date:   Sat Jan 11 08:55:36 2020 -0500

    Issue 5659/8: Remove Interval_t<T>::T_to_string ()

commit a66ebb85d9a08e197623638c2ffcd1ed8692adc8
Author: Dan Eble <address@hidden>
Date:   Sat Jan 11 08:36:42 2020 -0500

    Issue 5659/7: Finally remove deleted ::to_string () overloads

commit 834319e8c0db6029e8e42d285a272c21a94213dc
Author: Dan Eble <address@hidden>
Date:   Sat Jan 11 10:09:57 2020 -0500

    Issue 5659/6: Delete ::to_string (i) for various integer types

commit 37bd4763896cbebdddc28f0dcf4f905e723b1a5a
Author: Dan Eble <address@hidden>
Date:   Fri Jan 10 17:29:22 2020 -0500

    Issue 5659/5: Delete ::to_string (bool)

commit a02d3f0af7e81c760dcf622a1300e2a687750752
Author: Dan Eble <address@hidden>
Date:   Sat Jan 11 09:08:10 2020 -0500

    Issue 5659/4: Delete ::to_string (char, ssize_t)

    Where necessary, construct a std::string directly.

commit 8ea3c332016be0cc7bfdb9694f5489adfce577fe
Author: Dan Eble <address@hidden>
Date:   Fri Jan 10 16:45:25 2020 -0500

    Issue 5659/3: Delete ::to_string (const string&)

commit 8c3c5a4cadd5a3b9b1020f758fcaa9ad60e514e6
Author: Dan Eble <address@hidden>
Date:   Sat Jan 11 10:09:02 2020 -0500

    Issue 5659/2: Remove String_convert::char_string

    Where necessary, construct a std::string directly.

commit 446dbaff5494e2c86b3e397b80f0c3e68471f784
Author: Dan Eble <address@hidden>
Date:   Sat Jan 11 09:07:24 2020 -0500

    Issue 5659/1: Remove some unused string-related functions

    * ::string_copy
    * String_convert::pointer_string
    * String_convert::precision_string
    * String_convert::rational_string

---

[issues:#5659] Clean up to_string () etc.

Status: Fixed
Labels: Fixed_2_21_0
Created: Sat Jan 11, 2020 08:05 PM UTC by Dan Eble
Last Updated: Sun Jan 19, 2020 01:52 PM UTC
Owner: Dan Eble

C++11 provides std::to_string () overloaded for basic integer types.
This set of changes removes similar global functions from flower to
avoid ambiguity.

There is some other general clean-up in here, but it's all related to
strings.

1: Remove some unused string-related functions

2: Remove String_convert::char_string
Where necessary, construct a std::string directly.

3: Delete ::to_string (const string&)

4: Delete ::to_string(char, ssize_t)

5: Delete ::to_string (bool b)

6: Delete ::to_string (i) for various integer types

7: Finally remove deleted ::to_string () overloads

8: Remove Interval<t>::T_to_string ()
This has an example of a technique that was not previously usable
because of ambiguity between std::to_string () and ::to_string ().</t>

https://codereview.appspot.com/583320043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto