lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5658 Include


From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5658 Include <cmath> consistently, not <math.h>
Date: Fri, 17 Jan 2020 06:46:26 -0000

commit 20c9983553e9883a899d7e10156a0e34b8900648 (HEAD -&gt; dev/issue-5658-include-cmath, origin/staging)
Author: Dan Eble &lt;address@hidden&gt;
Date:   Fri Jan 10 20:53:26 2020 -0500

    Issue 5658/3: Cleanup: !isinf &amp;&amp; !isnan == isfinite
commit bb711884c61975474387ae6da10be378c129d3b4
Author: Dan Eble &lt;address@hidden&gt;
Date:   Fri Jan 10 18:54:20 2020 -0500

    Issue 5658/2: Qualify isinf, isnan, isfinite with std::

    This is necessary because we have seen an implementation of the standard
    library that defines ::isinf when certain headers other than math.h are
    included, so just avoiding math.h is not enough.
commit 0376c35dbd5b9917fdfb61c80a94ccb3d6b0a997
Author: Dan Eble &lt;address@hidden&gt;
Date:   Thu Jan 9 16:40:46 2020 -0500

    Issue 5658/1: Include &lt;cmath&gt; consistently, not &lt;math.h&gt;

    In the past, we had problems with std::isinf and std::isnan not being
    provided by &lt;cmath&gt; because they are C++11 features, so we were
    including &lt;math.h&gt; in some places, and even potentially defining our
    own isinf().

    Now, we are using C++11.  Because the code is also graced with
    &#34;using namespace std;&#34; all over the place (see issue 4550), ambiguity
    may arise.  Using &lt;cmath&gt; consistently and removing our local definition
    of isinf() should improve the situation.

[issues:#5658] Include <cmath> consistently, not <math.h>

Status: Fixed
Labels: Fixed_2_21_0
Created: Thu Jan 09, 2020 09:45 PM UTC by Dan Eble
Last Updated: Thu Jan 16, 2020 07:42 PM UTC
Owner: Dan Eble

In the past, we had problems with std::isinf and std::isnan not being
provided by <cmath> because they are C++11 features, so we were
including <math.h> in some places.

Now, we are using C++11. Because the code is also graced with
using namespace std; all over the place (see issue 4550), ambiguity
may arise. Using <cmath> consistently should improve the situation.

https://codereview.appspot.com/569220043


Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]