[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5650 Use C++11 "override" keyword

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• Description has changed:

Diff:

• Needs: -->
• Patch: new --> review
• Type: --> Enhancement
• Comment:

Passes make, make check and a full make doc.

---

[issues:#5650] Use C++11 "override" keyword

Status: Started
Created: Wed Jan 01, 2020 10:06 PM UTC by Dan Eble
Last Updated: Wed Jan 01, 2020 10:13 PM UTC
Owner: Dan Eble

1: Remove unnecessary include and namespace use

2: Check name in DECLARE_CLASSNAME()

3: Separate DECLARE_CLASSNAME() from VIRTUAL_COPY_CONSTRUCTOR()

4: Eliminate VIRTUAL_COPY_CONSTRUCTOR()

Just write out the virtual clone() function.

5: Use C++11 "override" keyword throughout the code

The chosen style is to state "virtual" for the base function only, because "override" implies "virtual".

6: Compile with -Werror=suggest-override, when supported

This fails the build if a virtual method is overridden without using the "override" keyword. This complements the standard behavior of failing the build if a virtual method with the "override" keyword does not actually override anything.

https://codereview.appspot.com/551320043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto