[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5648 Allow us

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5648 Allow user to provide CXXFLAGS on command line

Date:

Tue, 31 Dec 2019 14:33:19 -0000

labels: --> Fixed_2_21_0
status: Started --> New
Patch: push -->
Type: Enhancement --> Build
Comment:

commit 03a98b33f1f7a809e781f9ce161c336309ae2802
Author: Dan Eble &lt;address@hidden&gt;
Date:   Wed Dec 25 09:27:19 2019 -0500

    Issue 5648/3: Stop copying FlexLexer.h

    Leave FlexLexer.h where it is, rather than copying it to $(outdir).

    As we enable more warnings, we will not want to hear about problems in
    this file.  g++ automatically suppresses warnings for headers found in
    system include directories (specified with -isystem), so the simple
    solution is to leave it where it is.

commit 33852cdbe54abe99e39a23e03f4a4c2a855f6911
Author: Dan Eble &lt;address@hidden&gt;
Date:   Mon Dec 23 17:16:22 2019 -0500

    Issue 5648/2: move CXXFLAGS to the end of ALL_CXXFLAGS

    This allows CXXFLAGS=... on the command line to override flags in
    ALL_CXXFLAGS.

commit a9ff74a3dd25c89b2f49923547a82654c8e9f49e
Author: Dan Eble &lt;address@hidden&gt;
Date:   Mon Dec 23 17:16:22 2019 -0500

    Issue 5648/1: move -Woverloaded-virtual from CXXFLAGS to EXTRA_CXXFLAGS

[issues:#5648] Allow user to provide CXXFLAGS on command line

Status: New
Labels: Fixed_2_21_0
Created: Wed Dec 25, 2019 09:07 PM UTC by Dan Eble
Last Updated: Tue Dec 31, 2019 11:40 AM UTC
Owner: Dan Eble

I've found these changes helpful while experimentally enabling some
optional warnings. I'm submitting these on their own because I'm not
sure how much longer I'll need to finish up the related warning work.

1: move -Woverloaded-virtual from CXXFLAGS to EXTRA_CXXFLAGS

2: move CXXFLAGS to the end of ALL_CXXFLAGS

This allows CXXFLAGS=... on the command line to override flags in
ALL_CXXFLAGS.

3: Stop copying FlexLexer.h

Leave FlexLexer.h where it is, rather than copying it to $(outdir).

As we enable more warnings, we will not want to hear about problems in
this file. g++ automatically suppresses warnings for headers found in
system include directories (specified with -isystem), so the simple
solution is to leave it where it is.

https://codereview.appspot.com/551300043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.