[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5629 Staff

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5629 Staff_sy

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5629 Staff_symbol clean-up

Date:

Wed, 11 Dec 2019 16:07:53 -0000

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
Type: Enhancement --> Defect
Comment:

commit 5cf79d355654fe2fae3720eba84877e13b96abc6
Author: Dan Eble &lt;address@hidden&gt;
Date:   Fri Dec 6 10:59:26 2019 -0500

    Issue 5629/4: Make height of a no-line staff [0, 0] rather than empty

    This fixes a bug in the output of input/regression/rest-positioning.ly,
    in which a staff-group bracket failed to extend to a no-line staff.

commit 6613cee7a07ba7cc5b975e4d07257a8f090c328d
Author: Dan Eble &lt;address@hidden&gt;
Date:   Fri Dec 6 10:56:46 2019 -0500

    Issue 5629/3: Use ly_scm2floatvector in Staff_symbol::line_positions

commit 68d339a89f386747e67a5fca92189f6f0f61095e
Author: Dan Eble &lt;address@hidden&gt;
Date:   Fri Dec 6 10:50:48 2019 -0500

    Issue 5629/2: Remove unused Staff_symbol::line_count ()

    ... and Staff_symbol_referencer::line_count ()

commit c102b83a8f165edf4955dd8e7bd758f639cb54be
Author: Dan Eble &lt;address@hidden&gt;
Date:   Fri Dec 6 10:45:53 2019 -0500

    Issue 5629/1: Reduce unnecessary access of line-positions property

    In some places, Staff_symbol had already checked line-positions before
    calling line_count (), which checked it again.

[issues:#5629] Staff_symbol clean-up

Status: Fixed
Labels: Fixed_2_21_0
Created: Fri Dec 06, 2019 05:13 PM UTC by Dan Eble
Last Updated: Wed Dec 11, 2019 01:34 PM UTC
Owner: Dan Eble

1: Reduce unnecessary access to line-positions property

In some places, Staff_symbol had already checked line-positions before calling line_count (), which checked it again.

2: Remove unused Staff_symbol::line_count () and Staff_symbol_referencer::line_count ()

3: Use ly_scm2floatvector () in Staff_symbol::line_positions ()

4: Make height of a no-line staff [0, 0] rather than empty

This fixes a bug in the output of input/regression/rest-positioning.ly, in which a staff-group bracket failed to extend to a no-line staff.

https://codereview.appspot.com/571210043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

[Prev in Thread]

Current Thread

[Next in Thread]