[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5617 Prepare

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5617 Prepare for encoding changes in Python 3

Date:

Thu, 28 Nov 2019 19:28:22 -0000

labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
Comment:

pushed to staging as

commit 8e91e66158343996515c838366bbf03a45b25a5b
Author: Jonas Hahnfeld &lt;address@hidden&gt;
Date:   Sat Nov 23 10:03:14 2019 +0100

    Issue 5617/3: Open midi and musicxml files in binary mode

    When reading input files, only decode once we are sure that the
    content is not compressed and is properly encoded with UTF-8.

commit 66d03bf31fcefd482356d6afafa41212e8269ee9
Author: Jonas Hahnfeld &lt;address@hidden&gt;
Date:   Sat Nov 23 09:57:50 2019 +0100

    Issue 5617/2: Submit bytes-like objects to processes

    Encode strings before writing to input and decode result after reading
    from output or error stream.

commit 80da1d8a2986a312323b18d654606ca1467f1cef
Author: Jonas Hahnfeld &lt;address@hidden&gt;
Date:   Sat Nov 23 09:48:27 2019 +0100

    Issue 5617/1: Encode strings before hashing

    Python 3 requires &#34;bytes-like objects&#34;. Apparently we can already
    do so in Python 2, even though not needed for correctness.

[issues:#5617] Prepare for encoding changes in Python 3

Status: Fixed
Labels: Fixed_2_21_0
Created: Sat Nov 23, 2019 03:08 PM UTC by Jonas Hahnfeld
Last Updated: Thu Nov 28, 2019 05:57 AM UTC
Owner: Jonas Hahnfeld

Prepare for encoding changes in Python 3

This is most of the remaining diff for porting to Python 3,
but this also works in Python 2.4 already (even though not
strictly needed).

Individual changes:
1. Encode strings before hashing

Python 3 requires "bytes-like objects". Apparently we can already
do so in Python 2, even though not needed for correctness.

Submit bytes-like objects to processes

Encode strings before writing to input and decode result after reading
from output or error stream.

Open midi and musicxml files in binary mode

Only decode once we are sure that the content is not compressed.

http://codereview.appspot.com/573280043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.