[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5618 configure: Fix tests for compiler warning flags.

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

IMHO there are already too many "ugh" hacks in the build system. This double definition has been there for many years, so I don't see why we need a "temporary" fix (that might stay langer than wanted, as usual when saying "temporary"). But if you think we need it, please go ahead

---

[issues:#5618] configure: Fix tests for compiler warning flags.

Status: Started
Created: Sat Nov 23, 2019 09:03 PM UTC by Werner LEMBERG
Last Updated: Thu Nov 28, 2019 06:25 AM UTC
Owner: Werner LEMBERG

AC_LANG_PROGRAM ignores compiler warnings. This behaviour made the tests
always true and thus without any effect. We now add -Werror to enforce an
error in case the warning flag is not known.

To make that work it is also necessary to compile confdefs.h without
warnings; we add a hack to undefine macro PACKAGE_NAME, which gets defined
twice for historical reasons.

https://codereview.appspot.com/551210043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto