[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5617 Prepare for encoding changes in Python 3

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• Patch: countdown --> push
• Comment:

Patch counted down - please push.

---

[issues:#5617] Prepare for encoding changes in Python 3

Status: Started
Created: Sat Nov 23, 2019 03:08 PM UTC by Jonas Hahnfeld
Last Updated: Mon Nov 25, 2019 12:14 PM UTC
Owner: Jonas Hahnfeld

Prepare for encoding changes in Python 3

This is most of the remaining diff for porting to Python 3,
but this also works in Python 2.4 already (even though not
strictly needed).

Individual changes:
1. Encode strings before hashing

Python 3 requires "bytes-like objects". Apparently we can already
do so in Python 2, even though not needed for correctness.

1. Submit bytes-like objects to processes

Encode strings before writing to input and decode result after reading
from output or error stream.

1. Open midi and musicxml files in binary mode

Only decode once we are sure that the content is not compressed.

http://codereview.appspot.com/573280043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto