lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 1367 di


From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 1367 discussion
Date: Wed, 13 Feb 2019 13:33:20 -0000

Diff:

--- old
+++ new
@@ -1,19 +1,20 @@
 *Originally created by:* *anonymous
-
 *Originally created by:* [v.villenave](http://code.google.com/u/v.villenave/)
 *Originally owned by:* [v.villenave](http://code.google.com/u/v.villenave/)

 As Mats noticed a few years ago, default \(Nederlands\) note names are hardcoded in the Note\_names\_engraver: in the following example, the notes are entered in Spanish but printed in Dutch.

-[http://lists.gnu.org/archive/html/lilypond-user/2007-03/msg00021.html](http://lists.gnu.org/archive/html/lilypond-user/2007-03/msg00021.html)
+http://lists.gnu.org/archive/html/lilypond-user/2007-03/msg00021.html

+~~~
 \version "2.13.37"
 \include "espanol.ly"
 notes = \relative do' \{ do re mi do \}
 \new Staff <<
-  \notes
-  \context NoteNames \{ \notes \}
->>
+   \notes
+  \context NoteNames \{ \notes \}
+<<
+~~~

 It would be more elegant to use the pitchnames variable \(just like \displayLilyMusic does\) so we could print note names in any language.

@@ -23,5 +24,4 @@

 OK, here’s a (I hope) much better patch that not only deals with the Note_name_engraver, but also aims to make all of the note-/pitch-naming functions more consistent and flexible (including in chord names). Included is a regtest showing off the new capabilities offered by this engraver, including quite a few user-settable properties and Scheme functions. (Documentation is not included yet though, as I’d like to first settle on an agreed feature set, property names and general mechanism.)

-Please let me know if you think I’m on the right track here:
-https://codereview.appspot.com/221710044/#ps60001
+https://codereview.appspot.com/221710044

[issues:#1367] Enhancement: NoteNames context should handle any note names language

Status: Started
Created: Wed Oct 27, 2010 02:45 PM UTC by Anonymous
Last Updated: Wed Feb 13, 2019 01:31 PM UTC
Owner: Valentin Villenave
Attachments:

Originally created by: anonymous
Originally created by: v.villenave
Originally owned by:* v.villenave

As Mats noticed a few years ago, default (Nederlands) note names are hardcoded in the Note_names_engraver: in the following example, the notes are entered in Spanish but printed in Dutch.

http://lists.gnu.org/archive/html/lilypond-user/2007-03/msg00021.html

\version "2.13.37"
\include "espanol.ly"
notes = \relative do' \{ do re mi do \}
\new Staff &lt;&lt;
   \notes
  \context NoteNames \{ \notes \}
<<

It would be more elegant to use the pitchnames variable (just like \displayLilyMusic does) so we could print note names in any language.

--

Valentin Villenave - 2019-02-02

OK, here’s a (I hope) much better patch that not only deals with the Note_name_engraver, but also aims to make all of the note-/pitch-naming functions more consistent and flexible (including in chord names). Included is a regtest showing off the new capabilities offered by this engraver, including quite a few user-settable properties and Scheme functions. (Documentation is not included yet though, as I’d like to first settle on an agreed feature set, property names and general mechanism.)

https://codereview.appspot.com/221710044


Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]