lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change a


From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.
Date: Tue, 18 Dec 2018 12:30:43 -0000

Diff:

--- old
+++ new
@@ -20,13 +20,5 @@
 > Cheers,
 > Malte

-Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with.
+New Rietveld - http://codereview.appspot.com/369930043

-http://codereview.appspot.com/323040043 - part 1 of 3
-
-http://codereview.appspot.com/326870043 - part 2 of 3
-
-http://codereview.appspot.com/327970043 - part 3 of 3
-
-Note this will require both a convert.ly and a makelsr.py run to make sure that the patch passes all the tests.
-

[issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.

Status: Started
Created: Sun Sep 13, 2015 03:17 PM UTC by pkx166h
Last Updated: Tue Dec 18, 2018 12:29 PM UTC
Owner: Valentin Villenave

On 13/08/15 21:42, Malte Meyn wrote:

Hi list,

the case of the ‘c’ in partcombine is inconsistent, confusing me every
time I use \partcombine(Apart|Chords|…):

\partcombine, \partcombineApart, … but
\partCombineTextsOnNote, \partCombineListener

I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’.

Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the
engravers which use the more ‘natural’ underscore instead of camelCase
for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that
‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not
‘cueclefGlyph’), ‘Part_combine_engraver’ does.

I think that this would be rather easy to change.

Cheers,
Malte

New Rietveld - http://codereview.appspot.com/369930043


Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]