[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #3692 Fingerin

issue 3692: Fingering collision with accidentals

Changes to be committed:

modified: ../Documentation/changes.tely
- Announcing the new X-align-on-main-noteheads feature
for the New_fingering_engraver

new file: ../input/regression/fingering-adjacent-note-chord-new.ly
new file: ../input/regression/fingering-adjacent-note-chord.ly
- Adjacent-note chord regression tests for New_fingering_engraver
and Fingering_engraver.

modified: ../lily/fingering-engraver.cc
- Instead of aligning the fingering on the first-to-come notehead of the
chord, now use note-column as parent and take advantage of the
side-position-interface's X-align-on-main-noteheads functionality.
- The (sometimes) incorrect alignment caused by simply using the the
first chord note entered as parent was, after all, the actual reason
for the accidental collision that never had happened with a proper
fingering alignment.

modified: ../lily/new-fingering-engraver.cc
- Making New_fingering_engraver consider the X-align-on-main-noteheads
property and use note-column as parent for up/down orientations. That
way, up/down fingerings will be aligned in a straight column, properly
centered over the main noteheads.
- With "classic" per-note alignment, use notehead as parent (as it had
been always done), but now avoid all accidentals in the chord for
up/down placement.
- If there's only one note, no special alignment/accidental treatment
needed.
- accidentals_.clear () had been missing after position_all (), so that
more and more accidentals gathered up from chord to chord.
- By default, X-align-on-main-noteheads is not set to keep everything
compatible to the previous practice.
- When setting X-align-on-main-noteheads and using just up/down orientation,
New_fingering_engraver behaves like Fingering_engraver.

http://codereview.appspot.com/341470043

[issues:#3692] Fingering collision with accidentals

Status: Started
Created: Sat Nov 30, 2013 09:17 AM UTC by Anonymous
Last Updated: Sat Sep 08, 2018 01:33 PM UTC
Owner: Torsten Hämmerle
Attachments:

fingering.preview.png (4.6 kB; image/png)

Originally created by: *anonymous

Originally created by: address@hidden

Fingerings do not take accidentals into account, and fingerings align over the first note inout of a chord, rather than centering over the whole chord.
\version "2.17.96"

{
<e'' f'' cis'''>1 ^1^2^5
}

From Keith Ohara:
"Unfortunately this is a different bug -- or two -- so it will
not be fixed at the same time as collisions between Fingerings.

(1) LilyPond has never looked at Accidentals when placing Fingering;
until recently that caused only small overlaps with sharps because
the Fingering did not previously fit so close to the chord.

(2) Fingering on a chord as a whole should center over the main column
of note-heads; instead it centers over the first-input note.

So, you can do the same as we did when using version 2.12: rearrange
the order of pitches in the chord so a main-column note comes first.

{ <f'' e'' cis'''>1 ^1^2^5 }

***********
From Janek :

and i believe to solve it in a general way we would have to teach
lilypond about different kinds of extents - see:

http://lists.gnu.org/archive/html/lilypond-devel/2012-06/msg00230.html
https://code.google.com/p/lilypond/issues/detail?id=3239 (sorry, that
issue got pretty messy).

Currently the work i started on this is waiting until 2.18.0 is out...
What about leaving it for now and attacking this together after 2.18?
************
Possibly a Known Issue in NR 1.7.1 would be in order.

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

From:	Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject:	[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #3692 Fingering collision with accidentals
Date:	Sat, 08 Sep 2018 13:33:48 -0000