lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5391 Prob::eq


From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5391 Prob::equal_p: discard "origin" property
Date: Fri, 27 Jul 2018 11:07:39 -0000

Diff:


Passes make, make check and a full make doc.


[issues:#5391] Prob::equal_p: discard "origin" property

Status: Started
Created: Thu Jul 26, 2018 02:31 PM UTC by David Kastrup
Last Updated: Thu Jul 26, 2018 02:31 PM UTC
Owner: David Kastrup

Prob::equal_p: discard "origin" property

Previously elements of class Input was considered equal when compared
as part of Music property lists but this did not take into account
that some music might store its origin (if any) at different locations
in its property lists. So we just discard any "origin" property
completely, regardless of position in the property list and its actual
value type.

Also contains commit:

Don't set origin on copied music explicitly

There would be some mild incentive if the origin were accessed an
inordinary amount of times (and thus leaving it unset would maximize
access times to it) but there is no evidence for that. One reason
might be to ensure greater structural similarity between copies of
music, but Prob::equal_p has been changed to be robust against
differences here.

http://codereview.appspot.com/363740043


Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

reply via email to

[Prev in Thread] Current Thread [Next in Thread]